After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529942 - Don't catch all exceptions when parsing config
Don't catch all exceptions when parsing config
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2008-04-25 17:54 UTC by Richard Hult
Modified: 2008-04-25 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only catch Exceptions (1022 bytes, patch)
2008-04-25 17:55 UTC, Richard Hult 		accepted-commit_now Details | Review

Description Richard Hult 2008-04-25 17:54:24 UTC 
Changelog entry describes this best I think:

       * jhbuild/config.py: Only catch Exception, not all (most notably
        not BaseException exceptions). This stops exiting from the config
        file triggering a stack trace. Useful for more advanced jhbuildrc
        setups like we do for building GTK+ OS X.

BaseExceptions include SystemExit and pressing Ctrl-C etc, that is, not really errors.
Comment 1 Richard Hult 2008-04-25 17:55:27 UTC 
Created attachment 109921 [details] [review]
Only catch Exceptions
Comment 2 Frederic Peters 2008-04-25 18:01:28 UTC 
Sure, please commit.
Comment 3 Richard Hult 2008-04-25 18:22:10 UTC 
Thanks! Done.