After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529401 - Add preference to change activity on virtual desktop change
Add preference to change activity on virtual desktop change
Status: RESOLVED FIXED
Product: hamster-applet
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: hamster-applet-maint
hamster-applet-maint
: 580664 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-22 17:00 UTC by Toms Bauģis
Modified: 2010-01-18 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for workspace switching support (2.87 KB, patch)
2010-01-16 06:58 UTC, Ludwig Ortmann
needs-work Details | Review
improved version of attachment 151526 (3.07 KB, patch)
2010-01-16 12:02 UTC, Ludwig Ortmann
none Details | Review

Description Toms Bauģis 2008-04-22 17:00:40 UTC
Discussion in blog (http://projecthamster.wordpress.com/#comment-89) brought up idea, that maybe we could change current activity, when the virtual desktop is changed. Activity name could be derived from virtual desktop name.

From this option would benefit users of virtual screens, also i think it won't add big complexity to code.
Comment 1 David Prieto 2008-05-12 09:54:02 UTC
This would be the best thing ever. After using Hamster for some time I've found out its biggest bug is ME: me forgetting to tell it when I started working, me forgetting to tell it when I began procrastinating, me forgetting to tell it when I finished work...

This, plus not tracking when the computer is idle, would make Hamster track my activities accurately without almost no interaction on my side. Would make it almost perfect.

I love it.
Comment 2 Toms Bauģis 2008-05-12 09:55:25 UTC
Not tracking on idle is already in - you can adjust period after which hamster should stop tracking in gconf-editor: /apps/hamster-applet/general/timeout
Comment 3 David Prieto 2008-05-12 10:02:40 UTC
Thanks Toms :)

Is there any specific bug to discuss the idle thing? I would like to make a couple suggestions but I feel this is not the place.
Comment 4 Toms Bauģis 2008-05-12 10:51:55 UTC
how about bug 529097?
Comment 5 Toms Bauģis 2009-04-28 22:27:39 UTC
*** Bug 580664 has been marked as a duplicate of this bug. ***
Comment 6 Ludwig Ortmann 2010-01-16 06:58:15 UTC
Created attachment 151526 [details] [review]
patch for workspace switching support

The patch only changes applet.py, the preferences would probably have
to be patched as well .. I assume not everyone prefers this behaviour.
Comment 7 Ludwig Ortmann 2010-01-16 11:55:30 UTC
Review of attachment 151526 [details] [review]:

patch shows faulty behaviour due to misuse of api
Comment 8 Ludwig Ortmann 2010-01-16 12:02:09 UTC
Created attachment 151531 [details] [review]
improved version of attachment 151526 [details] [review]
Comment 9 Toms Bauģis 2010-01-17 12:40:11 UTC
Great stuff Ludwig!

There are some things to iron out, but you have provided a good start.
I could not get it working though due to some interesting bits in the logic, but i hope you don't mind if plough ahead and fix it, as that  might be faster and also the preference needs to be added anyway.

One thing that might turn out useful elsewhere for you: You are comparing variables using "is not" - that seems to me a bit dangerous, as the "is" operator performs instance checks, not value checks (that is it checks if the object instance is the same. That can lead to unexpected results as, for example,  floats are mutable and thus 'a=1.0; b=1.0; a is b' will yield false.
Comment 10 Toms Bauģis 2010-01-18 11:11:09 UTC
Workspace tracking is now in, and features two non-exclusive modes. First is option to switch to activity if workspace name matches, and second is remembering last activity for each workspace, as per Ludwig's patch.

Thanks, everyone!