After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528950 - trivial archive enhancements
trivial archive enhancements
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-04-19 20:06 UTC by David Zeuthen (not reading bugmail)
Modified: 2008-04-20 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.68 KB, patch)
2008-04-19 20:07 UTC, David Zeuthen (not reading bugmail) 		accepted-commit_now Details | Review
a few more fixes (3.92 KB, patch)
2008-04-20 18:48 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review

Description David Zeuthen (not reading bugmail) 2008-04-19 20:06:33 UTC 
Will attach a patch that sets the read-only bits on the returned FileInfo objects. This makes Nautilus present better error messages if the user tries to copy stuff onto the mount. Also, it will grey out a lot of non-ro operations in Nautilus such as Create Folder etc. Also, this patch will turn on thumbnailing of files from archive mounts. Which makes it look pretty nice.
Comment 1 David Zeuthen (not reading bugmail) 2008-04-19 20:07:05 UTC 
Created attachment 109558 [details] [review]
Proposed patch
Comment 2 David Zeuthen (not reading bugmail) 2008-04-19 20:08:36 UTC 
Ben, does this look good to you to commit to both stable and trunk? Thanks.
Comment 3 Benjamin Otte (Company) 2008-04-20 10:30:30 UTC 
Yeah, looks fine.
Comment 4 David Zeuthen (not reading bugmail) 2008-04-20 18:48:58 UTC 
Created attachment 109595 [details] [review]
a few more fixes

thanks.. I found two minor other issues

 - it's nicer to use from_commandline_arg to handle things file=/home/foo/bar.iso as well
 - usec are uint32, not uint64

which I committed as well. Thanks.
Comment 5 David Zeuthen (not reading bugmail) 2008-04-20 18:53:26 UTC 
Committed on both stable and gvfs-2-22

2008-04-20  David Zeuthen  <davidz@redhat.com>

        * daemon/gvfsbackendarchive.c: some minor fixes (#528950)