After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528175 - Add Linux IPv6 support to glibtop_get_proc_open_files
Add Linux IPv6 support to glibtop_get_proc_open_files
Status: RESOLVED OBSOLETE
Product: libgtop
Classification: Core
Component: general
2.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks: 528409
 
 
Reported: 2008-04-15 09:32 UTC by Mark McClelland
Modified: 2018-01-10 19:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
IPv6 patch (4.59 KB, patch)
2008-04-15 09:39 UTC, Mark McClelland 		reviewed Details | Review

Description Mark McClelland 2008-04-15 09:32:40 UTC 
The open files enumerating code in libgtop currently doesn't support IPv6 sockets. I have created a patch to add support for a new file type (GLIBTOP_FILE_TYPE_INET6SOCKET), along with the relevant parsing code for /proc/net/tcp6 for Linux systems. AFACT, FreeBSD is the only other platform where this library supports socket enumeration, but I didn't implement IPv6 there since I don't have a FreeBSD system to test on.
Comment 1 Mark McClelland 2008-04-15 09:39:19 UTC 
Created attachment 109289 [details] [review]
IPv6 patch
Comment 2 Benoît Dejean 2008-04-15 11:27:27 UTC 
Hello Mark, i'm pleased to see that there are still people who care about libgtop2 :).

Your patch is almost perfect (only the hashtable destruction is missing, no need to update the patch). I'm going to test it, then i'll first have to branch libgtop and i'll merge your patch. This is totally going into 2.24. I'll then update system-monitor 2.23.

Very nice work.
Comment 3 Mark McClelland 2008-04-15 22:10:22 UTC 
Thank you for those words!

If you haven't already updated system-monitor, I can submit a patch for that too. It was actually the reason that I made this patch.
Comment 4 Benoît Dejean 2008-04-17 14:52:03 UTC 
Anyway, i don't know why i never though of udp ...
Comment 5 GNOME Infrastructure Team 2018-01-10 19:46:03 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgtop/issues/8.