After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 527688 - inability to set the spellchecker's language
inability to set the spellchecker's language
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other All
: Normal enhancement
: ---
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2008-04-12 11:13 UTC by GreatBunzinni
Modified: 2011-12-17 04:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch implementing custom, per-newsgroup spellchecker language (5.95 KB, patch)
2008-08-21 11:33 UTC, Rui Maciel
reviewed Details | Review

Description GreatBunzinni 2008-04-12 11:13:18 UTC
Some Pan users subscribe to multiple newsgroups that host discussions in various different languages. Under that scenario, those Pan users aren't able to benefit from any spell checking.

It would be great if Pan supported multiple spell checking languages. It would be even greater if it was possible to set the default language according to the newsgroup being posted to.

Other information:
Comment 1 Rui Maciel 2008-08-21 11:33:47 UTC
Created attachment 117132 [details] [review]
Patch implementing custom, per-newsgroup spellchecker language

Patch made against rev. 360 of http://svn.gnome.org/svn/pan2/trunk
Comment 2 Rui Maciel 2008-08-21 11:38:00 UTC
I believe that this patch does the trick although, due to the limitations of GtkSpell v2 and the desire not to add another dependency to Pan, manually specifying the language tag isn't exactly an ideal solution. Nonetheless, as soon as GtkSpell v3 is released then I belive it will be trivial to implement this feature The Right Way ®
Comment 3 Duncan 2008-08-22 11:13:21 UTC
The patch applies cleanly here (to rev 361), and pan's running fine.  I see the new widget in group properties, but as I just do English, I haven't tested whether it actually /works/.  But at least it doesn't seem to break anything! =:^)

I'm submitting it to Gentoo for trials in at least their live-svn ebuild (which I submitted).  Whether it's introduced beyond that we'll see.

Duncan
Comment 4 Duncan 2008-08-22 12:14:51 UTC
Gentoo bug here:
http://bugs.gentoo.org/show_bug.cgi?id=235446

BTW, that version field should be 0.132 now, not the years-old 0.13.2, but that's not a field I can change.  Correcting it, if you can GB, will likely get way more attention from Charles.  He's pretty much ignoring the 0.14.x and previous bugs as that code is now unsupported and won't have any more releases.

Duncan
Comment 5 Gilles Dartiguelongue 2011-09-21 20:42:32 UTC
Could you please guys at least review the patch ?
Comment 6 Petr Kovar 2011-10-22 15:26:29 UTC
CC'ing Heinrich on this bug as I'm unsure whether he's aware of this.
Comment 7 Heinrich Müller 2011-12-17 01:52:21 UTC
Review of attachment 117132 [details] [review]:

seems ok. thanks a lot.
but the "combo" box is still just a single entry.
but it's a start. i'll implement the rest.
Comment 8 Heinrich Müller 2011-12-17 04:13:29 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.