After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 527552 - nautilus crashes when ther is no adress in the adress bar
nautilus crashes when ther is no adress in the adress bar
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
2.22.x
Other Linux
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 532531 532712 533506 538531 543920 549209 550782 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-11 14:45 UTC by Pedro Villavicencio
Modified: 2008-09-04 17:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
pretty simple fix (632 bytes, patch)
2008-04-14 09:01 UTC, A. Walton 		none Details | Review
another approach (1.49 KB, patch)
2008-04-14 10:12 UTC, Cosimo Cecchi 		none Details | Review

Description Pedro Villavicencio 2008-04-11 14:45:37 UTC 
this bug has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/213534

"When i just delete everything in the location bar and press Enter, Nautilus crashes and restart."

"Thread 3 (Thread 0xb4f26b90 (LWP 21409)):

+ Trace 194947

Thread 1 (Thread 0xb6ba0720 (LWP 21403))

  • #0 nautilus_file_invalidate_attributes
    at nautilus-file.c line 6407
  • #1 nautilus_file_invalidate_all_attributes
    at nautilus-file.c line 6442
  • #2 begin_location_change
    at nautilus-window-manage-views.c line 776
  • #3 nautilus_window_open_location
    at nautilus-window-manage-views.c line 606
  • #4 nautilus_window_go_to
    at nautilus-window.c line 237
  • #5 navigation_bar_location_changed_callback
    at nautilus-navigation-window.c line 481
  • #6 IA__g_cclosure_marshal_VOID__STRING
    at /build/buildd/glib2.0-2.16.3/gobject/gmarshal.c line 496
  • #7 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #8 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #9 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2199
  • #10 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #11 nautilus_navigation_bar_location_changed
    at nautilus-navigation-bar.c line 166
  • #12 IA__g_cclosure_marshal_VOID__VOID
    at /build/buildd/glib2.0-2.16.3/gobject/gmarshal.c line 77
  • #13 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #14 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #15 IA__g_signal_emitv
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2111
  • #16 gtk_binding_entry_activate
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkbindings.c line 536
  • #17 binding_match_activate
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkbindings.c line 1100
  • #18 gtk_bindings_activate_list
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkbindings.c line 1244
  • #19 IA__gtk_bindings_activate_event
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkbindings.c line 1338
  • #20 gtk_entry_key_press
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkentry.c line 2066
  • #21 nautilus_entry_key_press
    at nautilus-entry.c line 143
  • #22 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkmarshalers.c line 84
  • #23 g_type_class_meta_marshal
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 567
  • #24 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #25 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2478
  • #26 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2209
  • #27 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #28 gtk_widget_event_internal
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkwidget.c line 4678
  • #29 IA__gtk_window_propagate_key_event
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkwindow.c line 4936
  • #30 gtk_window_key_press_event
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkwindow.c line 4966
  • #31 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkmarshalers.c line 84
  • #32 g_type_class_meta_marshal
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 567
  • #33 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #34 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2478
  • #35 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2209
  • #36 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #37 gtk_widget_event_internal
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkwidget.c line 4678
  • #38 IA__gtk_propagate_event
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkmain.c line 2310
  • #39 IA__gtk_main_do_event
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkmain.c line 1556
  • #40 gdk_event_dispatch
    at /build/buildd/gtk+2.0-2.12.9/gdk/x11/gdkevents-x11.c line 2351
  • #41 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2009
  • #42 g_main_context_iterate
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2642
  • #43 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2850
  • #44 IA__gtk_main
    at /build/buildd/gtk+2.0-2.12.9/gtk/gtkmain.c line 1163
  • #45 main
    at nautilus-main.c line 569 






Comment 1


Diego Escalante Urrelo (not reading bugmail)





          2008-04-12 08:32:42 UTC
        



Confirmed!






Comment 2


A. Walton





          2008-04-14 09:01:38 UTC
        



Created attachment 109215 [details] [review]
pretty simple fix

We're not checking if the entry is empty in the Location Bar since the Great GIO Merge. This simply dupes the last location (which in turn makes the action of pressing return with the empty bar a no-op).






Comment 3


Cosimo Cecchi





          2008-04-14 10:12:09 UTC
        



Created attachment 109219 [details] [review]
another approach

Another approach to fix this, check if the entered location is empty before sending the LOCATION_CHANGED signal, and if it is emit the CANCEL one.






Comment 4


A. Walton





          2008-05-10 20:34:19 UTC
        



*** Bug 532531 has been marked as a duplicate of this bug. ***






Comment 5


A. Walton





          2008-05-12 08:17:15 UTC
        



*** Bug 532712 has been marked as a duplicate of this bug. ***






Comment 6


A. Walton





          2008-05-17 03:07:27 UTC
        



*** Bug 533506 has been marked as a duplicate of this bug. ***






Comment 7


Ted Percival





          2008-06-16 02:29:05 UTC
        



*** Bug 538531 has been marked as a duplicate of this bug. ***






Comment 8


A. Walton





          2008-06-30 11:44:28 UTC
        



This would be embarrassing not to fix before GNOME 2.22.3 goes out. Christian, can we commit Cosimo's patch?






Comment 9


Cosimo Cecchi





          2008-07-21 09:00:53 UTC
        



*** Bug 543920 has been marked as a duplicate of this bug. ***






Comment 10


Christian Neumair





          2008-07-21 09:48:36 UTC
        



Sorry Cosimo, I just prepeared and committed a similar patch without noting that you already cooked one up. Anyway, fixed in trunk:

http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14382

I do not emit the cancel signal, because Epiphany doesn't seem to cancel either.

Closing.






Comment 11


Cosimo Cecchi





          2008-08-26 10:39:52 UTC
        



*** Bug 549209 has been marked as a duplicate of this bug. ***






Comment 12


Cosimo Cecchi





          2008-09-04 17:46:27 UTC
        



*** Bug 550782 has been marked as a duplicate of this bug. ***