Created attachment 108923 [details] [review]
patch

Patch looks ok to me; slight race risk - but prolly not significant in practice.
Please do commit.

Committed, thanks for review :)

Created attachment 109205 [details] [review]
rework the patch.

If "127.0.0.1 localhost" is not configured in /etc/hosts, the incoming
requests from local is still probabally regarded as external requests
because getaddrinfo doesn't get the loop back ip address. I think
whatever whether the loop back address is configured or not, we can
hard-code these addresses into the source code.

Created attachment 109207 [details] [review]
remove the unused variable from the last patch.

By the way, I think Li's patch is not needed any more.

*** Bug 526700 has been marked as a duplicate of this bug. ***

If you don't have "localhost" setup to point to your local IP address - then yes, you're going to have serious issues :-) but the ORBit2 problems will prolly be the least of them ;->

Michael, do you think the patch is okey?

Copy Michael's e-mail here:

Sure - if it makes sense & the regression tests still pass, and you've
posted it to the ORBit2 list for comments - please do commit.
Ultimately, it's only you guys using the IPv4 stuff in the local-only
case.

Removed the patch of Li Yuan and Committed the new patch.