GNOME Bugzilla – Bug 527021
Make some functions private and remove them from bindings
Last modified: 2013-03-20 15:51:00 UTC
Some functions shouldn't be exported to the bindings. They need to be removed from the bindings, their declarations need to be moved to totem-private.h or, if possible, made static. totem_action_set_mrl_* would be candidates for being made static.
Having looked at it, totem_action_set_mrl_* aren't too easy to make static. They're referenced from totem-menu.c, totem-object.c and totem-session.c. The code in totem-object.c could be moved to totem.c without problems. The code in totem-menu.c could be reworked so that the playlist emits a "cleared" signal, and totem.c listens for that and clears the current MRL as appropriate. Perhaps the code in totem-session.c could be reworked to use totem_action_set_playlist_index instead of the totem_action_set_mrl_* functions. If so, they could be made static rather than just private.
Bastien, ping?
What's the list of functions that are exported to the bindings that shouldn't be?
I removed the totem_action_set_mrl_* functions from the bindings in revision #5350[1]. The question now is: can we make them completely static or private, even in the C API? [1]: http://svn.gnome.org/viewvc/totem?view=revision&revision=5350
I went through the totem.h header, and: 1) Renamed (nearly) everything to totem_object_* instead of totem_action_* and whatever else 2) Removed the signal emission functions, and a bunch of unused functions 3) Removed a number of functions available through totem_object_action_remote() (though we might be able to trim more if we removed playback control functions) The totem_action_set_mrl* are still there, and are only used in the dbusservice plugin. What's the OpenURI() function for? And should we use totem_object_add_to_playlist_and_play() instead, which ensures that the playlist is synced with what's playing as well (it could get pretty nasty).
(In reply to comment #5) > What's the OpenURI() function for? http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Method:OpenUri > And should we use > totem_object_add_to_playlist_and_play() instead, which ensures that the > playlist is synced with what's playing as well (it could get pretty nasty). The spec says “If the media player implements the TrackList interface, then the opened track should be made part of the tracklist”, so I guess we should be using add_to_playlist_and_play().
commit 150903cfeb78779bab5fe1e12c2c2a698ee5cf91 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Mar 20 16:50:09 2013 +0100 main: Don't export totem_action_set_mrl() in the API https://bugzilla.gnome.org/show_bug.cgi?id=527021 commit 9b2d0bf74c78f692fe366e9329a4a89a1ffd97cb Author: Bastien Nocera <hadess@hadess.net> Date: Wed Mar 20 16:47:34 2013 +0100 main: totem_action_set_mrl_and_play() doesn't need exporting It's only used inside totem-object.c https://bugzilla.gnome.org/show_bug.cgi?id=527021