After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526740 - Port gnome-vfs to gvfs
Port gnome-vfs to gvfs
Product: Evolution Exchange
Classification: Deprecated
Component: Connector
Other Linux
: Normal normal
: ---
Assigned To: Connector Maintainer
Ximian Connector QA
Depends on:
Reported: 2008-04-07 15:51 UTC by Milan Crha
Modified: 2008-04-17 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

proposed eex patch (2.81 KB, patch)
2008-04-07 22:14 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2008-04-07 15:51:00 UTC
Port gnome-vfs to gvfs
Comment 1 Milan Crha 2008-04-07 22:14:00 UTC
Created attachment 108820 [details] [review]
proposed eex patch

for evolution-exchange;

I will reuse the get_mime_type function whenever possible, even I do not expect many places anyway...
Comment 2 Matthew Barnes 2008-04-07 23:56:57 UTC
The documentation for g_file_new_for_uri() says it never fails (even if the URI is malformed) so the test for NULL is unnecessary.  Otherwise looks good.

That's gonna be a very handy function (surprised it's not already in GIO as a convenience function) and we should look at adding it to libedataserver or perhaps libcamel when you get around to porting E-D-S.
Comment 3 Milan Crha 2008-04-08 09:08:35 UTC
Yes, I thought I will publish such function through eds, but it depends on number of usages, and it probably doesn't worth it, though. I will see.

About the unnecessary check, I really want to be sure, so I check. And I guess the check doesn't hurt there, does it? Anyway, when something goes really wrong, then it can return NULL, so why not to check?
Comment 4 Matthew Barnes 2008-04-08 12:51:47 UTC
That's fine, not a big deal.  Please update after you commit, or have someone else update it.
Comment 5 Milan Crha 2008-04-17 17:01:52 UTC
Committed to trunk. Committed revision 1623.