GNOME Bugzilla – Bug 526740
Port gnome-vfs to gvfs
Last modified: 2008-04-17 17:02:04 UTC
Created attachment 108820 [details] [review]
proposed eex patch
I will reuse the get_mime_type function whenever possible, even I do not expect many places anyway...
The documentation for g_file_new_for_uri() says it never fails (even if the URI is malformed) so the test for NULL is unnecessary. Otherwise looks good.
That's gonna be a very handy function (surprised it's not already in GIO as a convenience function) and we should look at adding it to libedataserver or perhaps libcamel when you get around to porting E-D-S.
Yes, I thought I will publish such function through eds, but it depends on number of usages, and it probably doesn't worth it, though. I will see.
About the unnecessary check, I really want to be sure, so I check. And I guess the check doesn't hurt there, does it? Anyway, when something goes really wrong, then it can return NULL, so why not to check?
That's fine, not a big deal. Please update http://live.gnome.org/GioPort after you commit, or have someone else update it.
Committed to trunk. Committed revision 1623.