After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526015 - move gweather-xml parsing code to libgweather
move gweather-xml parsing code to libgweather
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: 2.22.0
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks: 526216
 
 
Reported: 2008-04-03 17:25 UTC by Dan Winship
Modified: 2008-04-07 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to move gweather-xml parsing to libgweather (15.11 KB, patch)
2008-04-03 17:31 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2008-04-03 17:25:06 UTC
Currently the old gweather applet and the new clock applet have nearly identical code to parse Locations.xml. Unfortunately, they both have the same bug, in that they skip over unrecognized start tags, but then they treat the corresponding end tag as if it closed the *parent node*, causing them to end up skipping over huge chunks of the file.

This moves gweather-xml to libgweather, and also fixes that parsing problem.
(I have separate patches to make gweather-applet and clock-applet use the new
API.)
Comment 1 Dan Winship 2008-04-03 17:31:45 UTC
Created attachment 108559 [details] [review]
patch to move gweather-xml parsing to libgweather
Comment 2 Vincent Untz 2008-04-07 08:54:11 UTC
Thanks Dan!