After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526013 - make Locations.xml validate, add "make check" test
make Locations.xml validate, add "make check" test
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: 2.22.0
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2008-04-03 17:17 UTC by Dan Winship
Modified: 2008-04-07 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (1.40 KB, patch)
2008-04-07 12:29 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2008-04-03 17:17:53 UTC 
this fixes Locations.xml.in to actually validate, and adds a make check test to test that it validates. (This means that a "make distcheck" will fail in the future if Locations.xml.in doesn't validate.)

the making-it-actually-validate part of this patch also appeared in the original version of the patch in bug 525451, but I'll be updating that
Comment 1 Vincent Untz 2008-04-07 10:21:18 UTC 
Dan: hrm, it seems you wanted to attach a patch?
Comment 2 Dan Winship 2008-04-07 12:29:40 UTC 
Created attachment 108776 [details] [review]
the patch

er, oops. yes :)
Comment 3 Vincent Untz 2008-04-07 12:43:54 UTC 
Thanks. I had fixed the xml earlier already, but hadn't added the check rule.