After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525977 - Glade 3 catalog file for GtkHTML
Glade 3 catalog file for GtkHTML
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: API
3.18.x
Other Linux
: Urgent major
: ---
Assigned To: gtkhtml-maintainers
Evolution QA team
evolution[composer]
Depends on:
Blocks: 522153
 
 
Reported: 2008-04-03 14:45 UTC by Matthew Barnes
Modified: 2008-04-06 02:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtkhtml-glade3-dep.diff (449 bytes, patch)
2008-04-04 06:17 UTC, Suman Manjunath
rejected Details | Review

Description Matthew Barnes 2008-04-03 14:45:36 UTC
Installation of the Glade 3 catalog file [1] in the new HTML editor has come up twice now as an issue, so I guess I need to rethink how I'm handling that.

The Makefile uses "pkg-config --variable=catalogdir gladeui-1.0" to learn where to install the file, which is usually something like /usr/share/glade3/catalogs.  But that will make the install script abort if the user is trying to install to a local prefix without root privileges.

We only install that file if maintainer mode is enabled in the build scripts (since the file is only for GtkHTML maintainers, and not needed for /using/ GtkHTML).  Problem is, the gnome-common scripts that are invoked by autogen.sh enable maintainer mode by default.  That means anyone that does a Subversion checkout and runs autogen.sh will be building with maintainer mode enabled, even if they're not a maintainer.

I think it might be better to give that file its own configure option, which is disabled by default:

   ./configure --with-glade-catalog

Especially since it should only really be needed on rare occasions.


[1] "Catalog" files are how Glade 3 prefers custom widgets be added to its
    widget palette.  The new HTML editor includes a few custom widgets that
    get referenced from the gtkhtml-editor.glade file.  The catalog file
    just lets you see the custom widgets and manipulate their properties
    from within Glade 3.
Comment 1 Matthew Barnes 2008-04-03 21:20:43 UTC
User complained of a jhbuild failure related to this:

/bin/bash ../../libtool --tag=CC   --mode=link ccache cc -DORBIT2=1 -pthread 
...
-rpath `/opt/gnome2/bin/pkg-config --variable=moduledir gladeui-1.0`
...
libtool: link: only absolute run-paths are allowed

Mostly likely caused by the absence of gladeui-1.0 (Glade 3).
Comment 2 Matthew Barnes 2008-04-03 21:24:18 UTC
Bumping severity and priority since three people have complained already.
Comment 3 Matthew Barnes 2008-04-04 04:10:11 UTC
Fixed in revision 8810.h

2008-04-04  Matthew Barnes  <mbarnes@redhat.com>

        * configure.in:
        Add a --with-glade-catalog option for installing Glade 3 catalog
        files (for maintainers only).  Defaults to 'no'.  Fixes several
        reported build breaks.  (#525977)
Comment 4 Suman Manjunath 2008-04-04 06:17:38 UTC
Created attachment 108592 [details] [review]
gtkhtml-glade3-dep.diff

don't we still need to patch JHBuild ? AFAIK, glade3 is not yet on the deps list for gtkhtml, yet. Attaching a patch which should fix that issue.
Comment 5 Matthew Barnes 2008-04-04 12:20:51 UTC
Glade 3 is unnecessary for building or using GtkHTML.  It's only needed by maintainers for modifying the gtkhtml-editor.glade file.  I'd rather not impose the dependency on everyone else.