After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525550 - GTK+ 2.13.0 GtkCurve test fails
GTK+ 2.13.0 GtkCurve test fails
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.13.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-04-01 14:18 UTC by ojab
Modified: 2008-11-12 15:15 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Negate large negativ and add test (2.92 KB, patch)
2008-10-06 15:51 UTC, Christian Dywan 		committed Details | Review
Ignore GtkCurve when testing (4.25 KB, patch)
2008-11-12 13:25 UTC, Christian Dywan 		committed Details | Review

Description ojab 2008-04-01 14:18:06 UTC 
Please describe the problem:
bash-3.2$ tests/objecttests -p /properties/GtkCurve
/properties/GtkCurve: 
Gtk-CRITICAL **: gtk_widget_set_size_request: assertion `width >= -1' failed
aborting...
Aborted

Steps to reproduce:
1. ./configure
2. make
3. make check


Actual results:


Expected results:


Does this happen every time?
Yes

Other information:
glib-2.16.1, pango-1.20.0, cairo-1.5.14, atk-1.22.0
Comment 1 Mart Raudsepp 2008-09-29 07:31:41 UTC 
Still happening with gtk+-2.14.3 (glib-2.18.1, cairo-1.6.4, pango-1.20.0)
Comment 2 Christian Dywan 2008-10-06 15:51:59 UTC 
Created attachment 120031 [details] [review]
Negate large negativ and add test

I see the failure, too. The curve basically ends up being extremely large, yet it has a negative width. This patch simply negates the width or height espectively in case it is negative and makes sure it fits in the screen. Not sure if that's the right fix.
The patch also adds a "curve" test to testgtk, which is a curve with four spin buttons to play around with.
Comment 3 Matthias Clasen 2008-11-11 20:59:03 UTC 
I suggest simply blacklisting GtkCurve in the tests. It is not as if we're going to fix GtkCurve.
Comment 4 Christian Dywan 2008-11-12 13:25:01 UTC 
Created attachment 122494 [details] [review]
Ignore GtkCurve when testing

This patch allows "" for the property to mean "skip entirely" and blacklists GtkCurve this way.

Plus three missing spaces before opening brackets while I was at it.
Comment 5 Matthias Clasen 2008-11-12 14:36:03 UTC 
Looks ok to me.
Comment 6 Christian Dywan 2008-11-12 15:15:46 UTC 
2008-11-12  Christian Dywan  <christian@imendio.com>

	Bug 525550 – GTK+ 2.13.0 GtkCurve test fails

	* gtk/tests/object.c (list_ignore_properties),
	(object_test_property), (main): Ignore GtkCurve when testing