GNOME Bugzilla – Bug 525072
use gio for file i/o
Last modified: 2021-05-25 17:47:08 UTC
Created attachment 108258 [details] [review]
patch to port ghex to use gio for file i/o
Could also overhaul ghex-window.c ghex_window_uri_exists() to use gio? That's the only part of ghex (as of 2.24.0) that uses gnome-vfs...would be nice to scrap that crufty old external dependency entirely.
Created attachment 129278 [details] [review]
Convert gnome-vfs to gio
*** Bug 590994 has been marked as a duplicate of this bug. ***
Hi, Could any GHex devel review the Daniel's patch?
I assume that ghex is unmaintained.
Yeah, ghex is essentially unmaintained. I am listed as a developer but only because I touched the repository last. Daniel's patch seems to just build on my patch, but mine was just a quick hack and probably needs to be refined a bit more before being committed. I don't really have much time to do either of those things at the moment.
If anybody is interested in ghex maintainership, feel free to volunteer.
I think my patch (Comment #3) is entirely different. Jonathon's (Comment #1) converts direct file access calls to use gio (example, using GFile *gfile=g_file_new_for_path() instead of FILE *file=fopen()). Mine converts gnomevfs to gio (example, using GFile *uri=g_file_new_for_uri instead of GnomeVFSURI *uri=gnome_vfs_uri_new()). There's no cross-talk or object-passing between the two sets of things being patched, they just happen to both involve migrations to the same new/modern library--each patch and idea is self-contained. Migrating to gio for standard access is a great feature. Scrapping gnomevfs is mandatory (as I understand it) for near-future gnome platform.
Daniels patch is so simple and obviously correct that we should probably just commit it. Jonathan, what do you think ?
Review of attachment 129278 [details] [review]:
Sure, feel free to commit.
Comment on attachment 129278 [details] [review]
Convert gnome-vfs to gio
GHex doesn't depends on gnome-vfs anymore, so removing dependency.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).
If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
and create a new enhancement request ticket at
Thank you for your understanding and your help.