After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525072 - use gio for file i/o
use gio for file i/o
Product: ghex
Classification: Applications
Component: general
Other All
: Normal normal
: ---
Assigned To: Jaka Mocnik
Jaka Mocnik
: 590994 (view as bug list)
Depends on:
Reported: 2008-03-30 04:45 UTC by Jonathon Jongsma
Modified: 2021-05-25 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch to port ghex to use gio for file i/o (21.18 KB, patch)
2008-03-30 04:45 UTC, Jonathon Jongsma
none Details | Review
Convert gnome-vfs to gio (1.21 KB, patch)
2009-02-22 19:40 UTC, Daniel Macks
committed Details | Review

Description Jonathon Jongsma 2008-03-30 04:45:07 UTC
patch attached.
Comment 1 Jonathon Jongsma 2008-03-30 04:45:38 UTC
Created attachment 108258 [details] [review]
patch to port ghex to use gio for file i/o
Comment 2 Daniel Macks 2009-02-22 19:08:23 UTC
Could also overhaul ghex-window.c ghex_window_uri_exists() to use gio? That's the only part of ghex (as of 2.24.0) that uses gnome-vfs...would be nice to scrap that crufty old external dependency entirely.
Comment 3 Daniel Macks 2009-02-22 19:40:53 UTC
Created attachment 129278 [details] [review]
Convert gnome-vfs to gio
Comment 4 Javier Jardón (IRC: jjardon) 2009-08-07 09:11:53 UTC
*** Bug 590994 has been marked as a duplicate of this bug. ***
Comment 5 Javier Jardón (IRC: jjardon) 2009-12-29 02:55:53 UTC
Hi, Could any GHex devel review the Daniel's patch?
Comment 6 André Klapper 2009-12-30 15:03:02 UTC
I assume that ghex is unmaintained.
Comment 7 Jonathon Jongsma 2009-12-30 15:25:04 UTC
Yeah, ghex is essentially unmaintained.  I am listed as a developer but only because I touched the repository last.  Daniel's patch seems to just build on my patch, but mine was just a quick hack and probably needs to be refined a bit more before being committed.  I don't really have much time to do either of those things at the moment.

If anybody is interested in ghex maintainership, feel free to volunteer.
Comment 8 Daniel Macks 2010-02-25 07:54:55 UTC
I think my patch (Comment #3) is entirely different. Jonathon's (Comment #1) converts direct file access calls to use gio (example, using GFile *gfile=g_file_new_for_path() instead of FILE *file=fopen()). Mine converts gnomevfs to gio (example, using GFile *uri=g_file_new_for_uri instead of GnomeVFSURI *uri=gnome_vfs_uri_new()). There's no cross-talk or object-passing between the two sets of things being patched, they just happen to both involve migrations to the same new/modern library--each patch and idea is self-contained. Migrating to gio for standard access is a great feature. Scrapping gnomevfs is mandatory (as I understand it) for near-future gnome platform.
Comment 9 Matthias Clasen 2010-04-10 20:53:48 UTC
Daniels patch is so simple and obviously correct that we should probably just commit it. Jonathan, what do you think ?
Comment 10 Jonathon Jongsma 2010-04-11 01:40:04 UTC
Review of attachment 129278 [details] [review]:

Sure, feel free to commit.
Comment 11 Javier Jardón (IRC: jjardon) 2010-04-26 16:34:27 UTC
Comment on attachment 129278 [details] [review]
Convert gnome-vfs to gio

commit d48fdd156cc1a924ce6d9a1d40dc2048e3b0fc1c
Comment 12 Javier Jardón (IRC: jjardon) 2010-04-26 16:35:44 UTC
GHex doesn't depends on gnome-vfs anymore, so removing dependency.
Comment 13 André Klapper 2021-05-25 17:47:08 UTC
GNOME is going to shut down in favor of
As part of that, we are mass-closing older open tickets in
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
and create a new enhancement request ticket at

Thank you for your understanding and your help.