GNOME Bugzilla – Bug 525028
dasher doesn't build with LDFLAGS="-Wl,--as-needed"
Last modified: 2008-03-30 23:29:16 UTC
We have a patch in gentoo since 4.5.2 that fixes building dasher with LDFLAGS="-Wl,--as-needed". The basics is really simple, order in linking matters. .a files must always precede libraries. See http://www.gentoo.org/proj/en/qa/asneeded.xml Patch to follow.
Created attachment 108241 [details] [review] dasher-4.7.0-as-needed.patch thanks for considering.
Gilles, thanks for the patch. What is there is fine. Did you intend to include changes to the default LDFLAGS in your patch, or just make it so that they can be included on the ./configure invocation?
Gilles, also a request. Do you happen to build with automake-1.10? If so does it work? I'm trying to determine if attachment 106658 [details] [review] fixes bug 398103.
I don't intend to make as-needed the default in dasher because it is something that afaik doesn't work on all architecture/os. But having a correct order in deps makes it available on arches which supports it. It is still not officially supported in gentoo as a default, even though a lot of people uses it, but I know that at least ubuntu and fedora uses it when it's possible to generate their packages. I use automake-1.10.1, I'll take a look at bug #398103 because it would remove 2 patches we have to support compilation without gnome support :) (See http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-accessibility/dasher/files/ and http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-accessibility/dasher/dasher-4.7.0.ebuild?rev=1.1&view=markup)
Committed id 108241 in r3487. Leaving bug open until I hear back about comment 3.
Created attachment 108273 [details] [review] dasher-4.7.0-gnome.patch here is the updated patch from the other bug, it didn't apply cleanly otherwise and allows building with "--without-gnome" combined with patch "dasher-4.6.1-gnome.patch"
Gilles, is attachment 108273 [details] [review] intended for bug bug 398103? If so, would you mind posting it there? I can do it myself, but I'd prefer it to be properly attributed, and I'll follow up there.
(In reply to comment #7) > Gilles, is attachment 108273 [details] [review] [edit] intended for bug bug 398103? I'm sorry, on my first read of your comment #5, I was confused. I believe you were saying the attachment from bug 398103 didn't apply cleanly to the 4.7.1 source. That is probably true (there were changes to the trunk since 4.7.1 that preceded the patch). The key is that you indicate after getting the patch applied, it works. I see that your patch is in error because: " $enable_scrollkeeper" = "xyes" can never be met (missing "x" preceeding "$enable_scrollkeeper". My patch also has a similar defect in the "$have_gdu" test. I'll fix both in trunk and close both these bugs. Thanks for your help.
hu I should have seen that :) anyway, thanks for reviewing those patches.