After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524992 - "Now Playing" status on website not reflected correctly
"Now Playing" status on website not reflected correctly
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Last.fm
git master
Other Linux
: Normal normal
: 1.2
Assigned To: Alex Hixon
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-29 16:37 UTC by Pepijn van de Geer
Modified: 2008-08-15 03:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Possible solution to bug. (3.02 KB, patch)
2008-03-30 05:28 UTC, Alex Hixon
none Details | Review
Updated patch (r4298) (3.02 KB, patch)
2008-07-30 02:04 UTC, Andrew Conkling
needs-work Details | Review

Description Pepijn van de Geer 2008-03-29 16:37:57 UTC
The currently playing song only shows for a very short time on Last.FM
This is probably because the last played song is submitted after the currently playing song. This erases the currently playing some from your Last.FM profile.
"Now Playing" should always be submitted after the rest of the songs are submitted.
This isn't in the spec and could be considered a Last.FM bug, but Banshee should work around that.
Comment 1 Alex Hixon 2008-03-30 05:28:57 UTC
Created attachment 108259 [details] [review]
Possible solution to bug.

I've come up with this patch.
Pepijn, could you please test this and see if you still encounter the above issue?

It doesn't seem to break anything for me, however. :)
Comment 2 Andrew Conkling 2008-07-29 12:32:54 UTC
Re-opening, we should get some feedback on the patch from the maintainers.
Comment 3 Andrew Conkling 2008-07-30 02:04:48 UTC
Created attachment 115536 [details] [review]
Updated patch (r4298)

I updated the patch for r4298.

Seems to work for me. Now Playing information was on my profile within 10 seconds. Good stuff.
Comment 4 Alex Hixon 2008-07-30 07:35:47 UTC
Thanks Andrew, I'll clean this up and apply (my bad for not originally doing that).
Comment 5 Andrew Conkling 2008-07-30 11:57:31 UTC
(In reply to comment #4)
> Thanks Andrew, I'll clean this up and apply (my bad for not originally doing
> that).

I thought I did clean it up? And don't worry about it; it worked when you submitted it, but AudioscrobblerConnection.cs has gotten some love recently. :)
Comment 6 Alex Hixon 2008-07-30 21:46:41 UTC
The commented out code at the beinning of NowPlaying() needs to be removed, and the now_playing_started variable should have a private identifier. Actually, if you happen to make those two minor changes today I'll simply commit the patch as soon as I get home this aftertoon.
Comment 7 Andrew Conkling 2008-08-15 02:19:13 UTC
(In reply to comment #6)
> the now_playing_started variable should have a private identifier.

I don't know how to do that. O:-) Could someone else update that?
Comment 8 Alex Hixon 2008-08-15 02:50:41 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 9 Andrew Conkling 2008-08-15 03:15:30 UTC
Thanks Alex!