GNOME Bugzilla – Bug 524704
non rfc2047 mail subject
Last modified: 2008-03-31 17:27:41 UTC
I saw a mail with non rfc 2047 subject with encoded words there, and I know why it does so, it's because spaces between words, which should not be there, but can we consider to support even such crappy implementations which creates this? It's obviously possible, so why not? The other thing is, in this particular case, the malformed this is not shown in a subject line at all, so that should be fixed too.
Created attachment 108133 [details] test email see the subject of this mail, the text is there twice, once with spaces, once without them. In evo 2.22 you can see there ". ." instead of ". =?...?= ." at the beginning of the subject line. But I would really prefer to see there properly decoded text, even the source is crappy a bit.
Created attachment 108169 [details] [review] proposed eds patch for evolution-data-server; I've such a feeling you will be against first chunk of this patch... But anyway, the rest is fine. One note for testers, the subject is decoded from the header and stored in a summary or something, so when you apply this patch, then in a message-list is subject still broken, but in preview window is fine.
Milan: aha, you found the culprit... I knew that my rfc2047_decode_text patch handled the tokenising properly! ;) anyways, my only suggestion is that instead of commenting out: + /* } else if (c==' ' || c==0x09) { + / * FIXME: this is an error! ignore for now ... * / ret = -1; - break; + break; */ it should probably just be removed. thanks!
Thx fejj for your review. Feel free to set commit now status. Milan, with the specified changes, commit it to stable/trunk.
Committed to trunk. Committed revision 8599. Committed to gnome-2-22. Committed revision 8600.