Bug 524341 – nautilus crashed with SIGSEGV in column_compare()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 524341 - nautilus crashed with SIGSEGV in column_compare()


Summary:	nautilus crashed with SIGSEGV in column_compare()


Status:	RESOLVED FIXED

Product:	nautilus
Classification:	Core
Component:	[obsolete] GIO
Version:	2.22.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Nautilus Maintainers
QA Contact:	Nautilus Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-03-25 17:07 UTC by Sebastien Bacher
Modified:	2009-04-21 13:52 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Attachments
patch (522 bytes, patch) 2008-03-25 17:37 UTC, Cosimo Cecchi	committed	Details \| Review

Description Sebastien Bacher 2008-03-25 17:07:50 UTC

The bug has been described on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/201023

"Thread 3 (process 8111):

+ Trace 193302

Thread 1 (process 8110)

#0 strv_index
at nautilus-column-utilities.c line 197
#1 column_compare
at nautilus-column-utilities.c line 213
#2 g_list_sort_real
at /build/buildd/glib2.0-2.15.6/glib/glist.c line 583
#3 g_list_sort_real
at /build/buildd/glib2.0-2.15.6/glib/glist.c line 629
#4 g_list_sort_real
at /build/buildd/glib2.0-2.15.6/glib/glist.c line 629
#5 g_list_sort_real
at /build/buildd/glib2.0-2.15.6/glib/glist.c line 629
#6 nautilus_sort_columns
at nautilus-column-utilities.c line 245
#7 apply_columns_settings
at fm-list-view.c line 1171
#8 fm_list_view_init
at fm-list-view.c line 1451
#9 IA__g_type_create_instance
at /build/buildd/glib2.0-2.15.6/gobject/gtype.c line 1575
#10 g_object_constructor
at /build/buildd/glib2.0-2.15.6/gobject/gobject.c line 1046
#11 IA__g_object_newv
at /build/buildd/glib2.0-2.15.6/gobject/gobject.c line 937
#12 IA__g_object_new_valist
at /build/buildd/glib2.0-2.15.6/gobject/gobject.c line 1027
#13 IA__g_object_new
at /build/buildd/glib2.0-2.15.6/gobject/gobject.c line 795
#14 fm_list_view_create
at fm-list-view.c line 2776
#15 nautilus_view_factory_create
at nautilus-view-factory.c line 69
#16 create_content_view
at nautilus-window-manage-views.c line 1138
#17 got_file_info_for_view_selection_callback
at nautilus-window-manage-views.c line 1029
#18 ready_callback_call
at nautilus-directory-async.c line 1260
#19 call_ready_callbacks_at_idle
at nautilus-directory-async.c line 1912
#20 g_idle_dispatch
at /build/buildd/glib2.0-2.15.6/glib/gmain.c line 4143
#21 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.15.6/glib/gmain.c line 2065
#22 g_main_context_iterate
at /build/buildd/glib2.0-2.15.6/glib/gmain.c line 2698
#23 IA__g_main_loop_run
at /build/buildd/glib2.0-2.15.6/glib/gmain.c line 2906
#24 IA__gtk_main
at /build/buildd/gtk+2.0-2.12.8/gtk/gtkmain.c line 1163
#25 main
at nautilus-main.c line 572
#26 __libc_start_main
from /lib/tls/i686/cmov/libc.so.6
#27 _start

Comment 1 Cosimo Cecchi 2008-03-25 17:37:57 UTC

Created attachment 108003 [details] [review]
patch

I really don't understand how both |all_columns| and |column_order| can be NULL there, but adding a NULL check before using |column_order| is not harmful and should solve this crash.

Comment 2 Alexander Larsson 2009-03-11 12:16:13 UTC

I agree its quite weird, there is probably some gconf setup issue.
However, checking for NULL is probably a good idea, even though it may just mean nautilus crashes in some other place due to the weird setup.

Comment 3 Cosimo Cecchi 2009-04-21 13:52:05 UTC

Fixed in master.

commit 7da1601ba6288e48dc6ed3023de03fff04d20b2d
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Tue Apr 21 15:49:31 2009 +0200

    Check for NULL when sorting columns
    
    Check for a NULL value of the order array when sorting the columns.
    This might help when dealing with strange GConf setup issues (#524341).