After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524273 - Transitions not shown correctly
Transitions not shown correctly
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: PDF
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks: 516749
 
 
Reported: 2008-03-25 10:03 UTC by Wouter Bolsterlee (uws)
Modified: 2010-04-05 09:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
patch (11.00 KB, patch)
2008-05-07 00:30 UTC, Carlos Garnacho 		none Details | Review
patch for transitions (9.63 KB, patch)
2009-05-07 08:37 UTC, Johan Brannlund 		none Details | Review

Description Wouter Bolsterlee (uws) 2008-03-25 10:03:21 UTC 
The transitions in [1] do not show correctly.

Expected: Fade from from A -> B
Actual: B flashes, followed by a fade from A -> B

[1] http://www.j5live.com/wp-content/uploads/2008/03/bossa_dbus_debugging_and_optimization.pdf
Comment 1 Carlos Garnacho 2008-05-07 00:30:44 UTC 
Created attachment 110499 [details] [review]
patch

This patch: 

* fixes this bug by not behaving as if the transition wasn't running until both origin and destination surfaces are available. 
* It also fixes #516749 by not waiting for the surfaces cache indefinitely when the destination surface is already available, and 
* also adds a subtle animation at the corner to provide feedback meanwhile the transition isn't ready (more suitable than the "loading..." label)
Comment 2 Johan Brannlund 2008-05-17 21:58:36 UTC 
Unfortunately, this patch does not seem to fix bug #516749. I applied the patch to evince 2.22.1 and still have the issue that's described in that bug.
Comment 3 Jean-François Fortin Tam 2008-11-25 19:20:53 UTC 
Since bug #516749 being fixed now, what would be the status of this bug?
Comment 4 Nickolay V. Shmyrev 2009-03-31 20:38:00 UTC 
Carlos, I accidentally fixed this bug recently just by applying part of the patch. Should I apply the rest?
Comment 5 Johan Brannlund 2009-05-06 19:17:26 UTC 
Evince 2.26.1 still has this bug, but applying the patch fixes it (after some manual fixes to make it apply).
Comment 6 Nickolay V. Shmyrev 2009-05-06 22:32:29 UTC 
Johan, if you'll post the updated patch, that would be appreciated.
Comment 7 Johan Brannlund 2009-05-07 08:36:59 UTC 
Sure. Here's the updated patch. It could probably use some more cleanup, but this works for me.
Comment 8 Johan Brannlund 2009-05-07 08:37:46 UTC 
Created attachment 134178 [details] [review]
patch for transitions
Comment 9 Carlos Garcia Campos 2010-01-04 13:44:31 UTC 
hmm, I had forgotten this bug. The dbus presentation works perfectly for me with current git master. Carlos, do you think it's still needed any of the changes in your patch? do we really need progress animation?
Comment 10 Carlos Garnacho 2010-01-18 10:38:35 UTC 
Hmm, honestly I'm not sure, it depends on how much time it may take to render a page, so user feedback is provided or not :), If you feel it isn't needed, then it probably isn't...
Comment 11 Tobias Mueller 2010-04-05 00:25:21 UTC 
Hm. So given that it works, we can close this bug as OBSOLETE then, no?