GNOME Bugzilla – Bug 523958
update lock icons to tango style
Last modified: 2008-07-08 16:05:27 UTC
There are two lock icons - stock_lock-open.png and stock_lock.png - which are used in Epiphany to represent the http and https URI schemes respectively, they can be seen quite often. Unfortunately they haven't been updated with the recent new style of the GNOME icon theme, they don't look good. They were added at least 3 and 4 years ago respectively, according to the GNOME SVN repository. Could they please be updated?
Epiphany should use the security-* icons instead. Their choice to ship copies of the old style icons is an epiphany issue, not gnome-icon-theme.
Epiphany is not using these g-i-t icons on purpose, see bug 348350 comment 93 ff. Of couse, we're open to updating the lock icons to tango style, it's just that nobody has provided them.
(In reply to comment #2) > Epiphany is not using these g-i-t icons on purpose, see bug 348350 comment 93 > ff. Well, since we added the shields to g-i-t, and the symlinks to icon-naming-utils, epiphany switched from using the old names, to shipping its own copies. I think that classifies as "on purpose" really. I'm pretty sure it wasn't accidental, that the choice was made to do so. > Of couse, we're open to updating the lock icons to tango style, it's just that > nobody has provided them. There are Tango styled lock icons in gnome-icon-theme-extras in svn. I would still advise against using them though, and instead using the system theme icons for security.
(In reply to comment #3) > (In reply to comment #2) > > Epiphany is not using these g-i-t icons on purpose, see bug 348350 comment 93 > > ff. > > Well, since we added the shields to g-i-t, and the symlinks to > icon-naming-utils, epiphany switched from using the old names, to shipping its > own copies. I think that classifies as "on purpose" really. I'm pretty sure it > wasn't accidental, that > the choice was made to do so. That's exactly what I said. > There are Tango styled lock icons in gnome-icon-theme-extras in svn. I see only locked and unlocked icons, no broken-lock icon. And althought they're in pixel-size directories (22x22 etc), they're svgs not pngs...
IIRC we didn't switch to shields because we believed the lock was a more desktop-platform-browser-agnostic concept.
(In reply to comment #4) > (In reply to comment #3) > > There are Tango styled lock icons in gnome-icon-theme-extras in svn. > > I see only locked and unlocked icons, no broken-lock icon. And althought > they're in pixel-size directories (22x22 etc), they're svgs not pngs... rsvg file.svg file.png
(In reply to comment #5) > IIRC we didn't switch to shields because we believed the lock was a more > desktop-platform-browser-agnostic concept. The reasoning expressed in the aforementioned bug 348350 is that it is what banks and other organizations tell their customers to look for. Which also makes it more insecure, because it's exactly what phishing sites put on display for the customer to see. Also, the lock is used for password dialogs, regardless of whether the data stream that the password is sent over, is secure or not. This means that the metaphor is diluted and doesn't actually represent the level of security one expects it to, if they don't know what's going on already. A plain text password sent over normal http 401 auth will have the same icon as a "secured" website connected to with a valid ssl certificate. That seems broken to me. :)
That is a valid point.
http://svn.gnome.org/viewvc/epiphany?view=revision&revision=8325 Doesn't this commit mean that this bug is now fixed?
(In reply to comment #9) > http://svn.gnome.org/viewvc/epiphany?view=revision&revision=8325 > > Doesn't this commit mean that this bug is now fixed? Since you filed the bug, feel free to close it if you think it has been fixed. :)
Yes, FIXED.