After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523630 - Google contact API support for libgdata/libgdata-google
Google contact API support for libgdata/libgdata-google
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.22.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks: 523632
 
 
Reported: 2008-03-20 20:42 UTC by Jörgen Scheibengruber
Modified: 2008-04-17 07:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch described above (46.98 KB, patch)
2008-03-20 20:43 UTC, Jörgen Scheibengruber 		committed Details | Review
Patch that makes the google calendar backend compile with the new api (4.11 KB, patch)
2008-03-20 21:18 UTC, Jörgen Scheibengruber 		committed Details | Review

Description Jörgen Scheibengruber 2008-03-20 20:42:24 UTC 
Attached you find a patch that adds some new API's to GDataEntry and GDataFeed so that those can be used with the feeds returned by Googles just recently release contact API.

Moreover this changes the gdata-service-iface (and the derived gdata-google-service) API in the following manner:

- just as the create-API, the update APIs will return the new GDataEntry (containing the new revision-string) that the server sends as a response for a successfull update (or NULL in case an error happens) 
- the delete API will return a gboolean indicating success resp. failure
- all apis take an GError, which will pass the HTTP/libsoup error code to the caller
Comment 1 Jörgen Scheibengruber 2008-03-20 20:43:42 UTC 
Created attachment 107704 [details] [review]
Patch described above
Comment 2 Jörgen Scheibengruber 2008-03-20 20:45:53 UTC 
I'll attach a patch for the google calendar backend as soon as I have it ready.
Comment 3 Jörgen Scheibengruber 2008-03-20 21:18:38 UTC 
Created attachment 107706 [details] [review]
Patch that makes the google calendar backend compile with the new api

This is just a quick fix; the patch does not actually make use of the error-handling of the new API. Someone that knows calendar backends better than me should do that (if needed at all).
Comment 4 Ross Burton 2008-03-26 10:27:24 UTC 
As the only code which (currently) uses this is in the calendar, re-assingining it so that relevant people get mailed.
Comment 5 Ross Burton 2008-03-26 10:29:31 UTC 
Jörgen, I recall you saying that you needed to bump the libsoup requirements.  Is that required for these changes, or just the contacts backend?
Comment 6 Jörgen Scheibengruber 2008-03-26 15:39:15 UTC 
No, actually libgdata already required libsoup 2.4 before my changes. So eds trunk already depends on soup 2.4, no changes needed.
Comment 7 Ross Burton 2008-03-26 15:48:51 UTC 
Okay, that is cool.
Comment 8 ebbywiselyn 2008-04-16 21:04:51 UTC 
I reviewed the patch and committed it to trunk with some minor changes. 

In revisions 8641 to 8649.
Comment 9 Srinivasa Ragavan 2008-04-17 05:10:08 UTC 
Setting the status accordingly.
Comment 10 Ross Burton 2008-04-17 07:02:31 UTC 
Closing as the patch is committed.