After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523480 - Unwanted roles appearing in the braille context for dojo in FF3
Unwanted roles appearing in the braille context for dojo in FF3
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.21.x
Other All
: Normal normal
: 2.22.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-03-19 22:25 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-04-04 18:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
revision 1 (1.67 KB, patch)
2008-03-21 02:23 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-03-19 22:25:22 UTC
Scott left some "bug" notes in his regression tests.  For a number of tests we are including "form", "section", "panel", and "list" where we shouldn't be.  This seems to be a combination of two things:

1. Whitespace that isn't getting stripped out

2. The default braillegenerator being called by updateBraille() for that object with the whitespace.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-03-21 02:23:48 UTC
Created attachment 107720 [details] [review]
revision 1

This gets rid of all of them but one.  And in that case, I'm not sure we do want to eliminate "panel" from the braille context.  I need to take a closer look and probably talk with Mike.

Pylinted and regression tested.  Mike, please test.
Comment 2 Mike Pedersen 2008-03-25 17:50:28 UTC
As we present panel in other applications we probably shouldn't remove it here.  This patch seems good. 
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-03-27 21:35:46 UTC
Thanks.  Patch committed to both the 2-22 branch and to trunk.  Moving to pending.