GNOME Bugzilla – Bug 523441
oowriter/bug_361624.py regression tests #1 through #4 produce the wrong results.
Last modified: 2008-04-04 18:32:08 UTC
Test 1 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py:Read first line in flat review mode EXPECTED: "BRAILLE LINE: 'panel EFFector Vol. 19, No. 38 October $l'", " VISIBLE: 'EFFector Vol. 19, No. 38 Octobe', cursor=1", "SPEECH OUTPUT: 'panel EFFector Vol. 19, No. 38 October ", "'", ACTUAL: "BRAILLE LINE: 'panel EFFector Vol. 19, No. 38 October Intercept Personal $l'", " VISIBLE: 'EFFector Vol. 19, No. 38 Octobe', cursor=1", "SPEECH OUTPUT: 'panel EFFector Vol. 19, No. 38 October Intercept Personal ", "'", Test 2 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py:Read line two in flat review mode EXPECTED: "BRAILLE LINE: '10, 2006 editor@eff.org * EFF Sues for Information on $l'", " VISIBLE: '10, 2006 editor@eff.org * EFF S', cursor=1", "SPEECH OUTPUT: '10, 2006 editor@eff.org", " * EFF Sues for Information on '", ACTUAL: "BRAILLE LINE: '10, 2006 editor@eff.org Communications $l'", " VISIBLE: '10, 2006 editor@eff.org Communi', cursor=1", "SPEECH OUTPUT: '10, 2006 editor@eff.org", " Communications", "'", Test 3 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py:Read line three in flat review mode EXPECTED: "BRAILLE LINE: ' Electronic Surveillance $l'", " VISIBLE: ' Electronic Surveillance $l', cursor=1", "SPEECH OUTPUT: '", " Electronic Surveillance ", "'", ACTUAL: "BRAILLE LINE: ' $l'", " VISIBLE: ' $l', cursor=1", "SPEECH OUTPUT: 'white space'", Test 4 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py:Read line four in flat review mode EXPECTED: "BRAILLE LINE: 'A Publication of the Electronic Systems $l'", " VISIBLE: 'A Publication of the Electronic ', cursor=1", "SPEECH OUTPUT: 'A Publication of the Electronic Systems", "'", ACTUAL: "BRAILLE LINE: 'A Publication of the Electronic Washington, D.C. - The FLAG $l'", " VISIBLE: 'A Publication of the Electronic ', cursor=1", "SPEECH OUTPUT: 'A Publication of the Electronic Washington, D.C. - The FLAG '",
This regression test is going a flat review of some of the lines in .../orca/test/keystrokes/oowriter/column-example.odt This document comes in two columns. The previous (EXPECTED) results just gave a flat review of the items in the first column. Now the (ACTUAL) results are giving us a flat review of all the items on each line but spanning two columns. I'd say what we are getting now is more correct. Will, do you agree? If so, I'll adjust the regression test results to match.
(In reply to comment #1) > This regression test is going a flat review of some of the lines > in .../orca/test/keystrokes/oowriter/column-example.odt > > This document comes in two columns. The previous (EXPECTED) results > just gave a flat review of the items in the first column. Now the > (ACTUAL) results are giving us a flat review of all the items on each > line but spanning two columns. > > I'd say what we are getting now is more correct. Will, do you agree? > If so, I'll adjust the regression test results to match. Yep, it is more correct for our current flat review implementation.
Created attachment 108088 [details] [review] Revision #1. Patch committed to SVN trunk. Moving to '[pending]'.
Thanks Mike. Closing as FIXED.