After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523414 - Can not import from any HTML or RDF file, even if Ephy created the file
Can not import from any HTML or RDF file, even if Ephy created the file
Product: epiphany
Classification: Core
Component: Bookmarks
Other All
: Normal major
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Reported: 2008-03-19 17:50 UTC by Chad Rodrigue
Modified: 2008-05-20 06:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

fix for importing bookmarks (631 bytes, patch)
2008-05-20 05:16 UTC, Sebastian Keller
committed Details | Review

Description Chad Rodrigue 2008-03-19 17:50:15 UTC
Please describe the problem:
Ephy 2.22.0 on Ubuntu Hardy cannot import bookmarks from either bookmarks.html or Bookmarks.rdf.  The import fucntion always bombs out with a dialog stating that the file is probably not of the supported type.

Steps to reproduce:
1. On a clean GNOME desktop, with an as-yet-unused Ephy 2.22.0, open the Bookmark manager and export the default bookmarks that are there.  It doesn't matter which format you choose (HTML or RDF).  
2. Once exported, try to import these files.
3. Ta-Da!!

Actual results:
A dialog appears informing the user that the file is likely not of the correct type; no bookmarks get imported.

Expected results:
I would expect the bookmarks to appear in Ephy's bookmark list.  

Does this happen every time?

Other information:
Comment 1 atomkarinca 2008-04-26 21:52:29 UTC
I can confirm this.
Comment 2 Reinout van Schouwen 2008-04-27 23:06:28 UTC
Marking NEW then.
Comment 3 Sebastian Keller 2008-05-20 05:16:48 UTC
Created attachment 111200 [details] [review]
fix for importing bookmarks

The FileInfo is unrefed too early, so the string "type" is pointing to does not contain that info any more, when it is compared.
Moving the unref fixes this.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2008-05-20 06:04:40 UTC
Committed to trunk and -22. HTML import is still broken.