After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523054 - gstbasesrc crashes when called from typefind helpers
gstbasesrc crashes when called from typefind helpers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-17 20:50 UTC by Milosz Derezynski
Modified: 2008-03-17 22:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Stack trace of the crash (4.82 KB, text/plain)
2008-03-17 20:51 UTC, Milosz Derezynski 		  Details
Fix for the crash (648 bytes, patch)
2008-03-17 22:02 UTC, Milosz Derezynski 		committed Details | Review

Description Milosz Derezynski 2008-03-17 20:50:27 UTC 
gst_base_src_get_range crashes when called from gsttypefindhelper code
Comment 1 Milosz Derezynski 2008-03-17 20:51:33 UTC 
Created attachment 107481 [details]
Stack trace of the crash
Comment 2 Milosz Derezynski 2008-03-17 20:58:59 UTC 
http://futurepast.free.fr/gst.log.bz2 contains the GST_DEBUG log to the crash
Comment 3 Milosz Derezynski 2008-03-17 22:02:03 UTC 
Created attachment 107485 [details] [review]
Fix for the crash

This is a fix for the crash as discussed on IRC (the _create code should only return to the caller when the FlowReturn is not GST_FLOW_OK, only then the calling function doesn't expect a buffer)
Comment 4 Sebastian Dröge (slomo) 2008-03-17 22:06:24 UTC 
2008-03-17  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Milosz Derezynski <internalerror at gmail dot com>

	* ext/gio/gstgiobasesrc.c: (gst_gio_base_src_create):
	  If seeking to a new position succeeds don't simply return from
	  create() without creating a buffer. Do this only in the case
	  seeking to the new position fails. Fixes bug #523054.