GNOME Bugzilla – Bug 522817
GNOME Dictionary doesn't match FreeDesktop directories specs
Last modified: 2012-02-23 15:17:20 UTC
Please describe the problem: I've found that GNOME Dictionnary 2.20 in GNOME 2.22 (Ubuntu Hardy alpha 6) places its files in .gnome2/gnome-dictionary/ which doesn't match FreeDesktop directories specs : The default for $XDG_CONFIG_HOME is $HOME/.config, the default for $XDG_DATA_HOME is $HOME/.local/share. So all applications should look for those environment variables and use those default values if the variables are not set. See http://www.freedesktop.org/wiki/Specifications/basedir-spec See also - http://ploum.frimouvy.org/?184-cleaning-user-preferences-keeping-user-data (main post and comment#8) - http://www.aigarius.com/blog/2007/01/10/fhs-extension-for-user-home-folders/ Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
the data is application specific and not meant to be shared at all, since the format might or might not change without any notice. not that I don't agree: we should probably move to XDG_CONFIG_HOME in the future and I'd gladly accept patches for that.
Created attachment 183790 [details] [review] Patch for gnome-dictionary to use an XDG compliant directory The patch changes the old $HOME/.gnome/gnome-dictionary path to the XDG-compliant $XDG_USER_CONFIG_DIR/gnome_dictionary.
Sorry for creating new bug for this: https://bugzilla.gnome.org/show_bug.cgi?id=659104 I've implemented patch with migration of configs from ~/.gnome2/gnome-dictionary to ~/.config/gnome-dictionary I'ts here: https://bugzilla.gnome.org/attachment.cgi?id=204562 Emmanuele, could you please review?
I think the general structure of the patch is good. Two suggestions: 1. The patch should not include whitespace changes, you can provide a separate patch for that (this also makes it easiert to review the patch) 2. Using of goto is discouraged, i would suggest not to use goto lables
Please change the bug status to confirmed or in progress
I think this bug is duplicate of: https://bugzilla.gnome.org/show_bug.cgi?id=659104 That bug has reviewed patch. Emmanuele promised to commit it before next version bump or something like that.
*** This bug has been marked as a duplicate of bug 659104 ***