GNOME Bugzilla – Bug 521612
Need new APIs in libnautilus-extension.
Last modified: 2008-04-04 15:58:51 UTC
In order to properly do the file-roller nautilus extension we need to check if the parent is writeable or not. Since nautilus already has that information we shouldnt be doing any I/O inside the extionsion but nautilus should just provide a way to get to this, at the moment internal, information.
I'd suggest a:
NautilusFileInfo * nautilus_file_info_get_parent_file_info (NautilusFileInfo *file);
gboolean nautilus_file_info_can_write (NautilusFileInfo *file);
Created attachment 107451 [details] [review]
Proposed patch, this adds the requested API.
nautilus-cd-burner would also like nautilus_file_get_mount() exposed.
getting this in would add new api. however bug 501542 depends on this and is a potential 2.22 blocker. maybe there should be a request to the release-team to add this also to the stable series to fix 501542 for 2.22.x.
Created attachment 107698 [details] [review]
Also expose nautilus_file_info_get_mount (). This was requested also by Davidz for gnome-mount in another report, which I'll be marking as a dup of this.
*** Bug 518700 has been marked as a duplicate of this bug. ***
> maybe there should be a request to the release-team to
add this also to the stable series to fix 501542 for 2.22.x.
desktop modules are not affected by API/ABI freeze.
Cosimo: Marking attachment 107698 [details] [review] as accepted-commit_now. Please commit it to trunk and the GNOME 2.22 branch.
I committed this along with a comment saying why it's not safe to call get_parent_info () multiple time recursively.
Closing as FIXED.
2008-04-04 Cosimo Cecchi <firstname.lastname@example.org>
Add new APIs for extensions to NautilusFileInfo (can_write, get_mount
and get_parent_info). (#521612).