After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521329 - Inconsistent behaviour of the 'previous track' button
Inconsistent behaviour of the 'previous track' button
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-09 08:17 UTC by Thomas Zander
Modified: 2008-04-08 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Consistent behaviour of 'previous track' functions throughout the application (1.88 KB, patch)
2008-03-09 08:20 UTC, Thomas Zander 		committed Details | Review

Description Thomas Zander 2008-03-09 08:17:03 UTC 
Depending on which 'previous track' button is pressed (in the shell player vs. all other possibilities such as the multimedia keys on the keyboard), either rb_shell_player_do_previous_or_seek() or rb_shell_player_do_previous() is executed.
This results that RB skips to the beginning of the current track when pressed on the main UI, but to the beginning of the previous track when pressed anywhere else (and the playtime is > 3 sesonds).
Comment 1 Thomas Zander 2008-03-09 08:20:34 UTC 
Created attachment 106887 [details] [review]
Consistent behaviour of 'previous track' functions throughout the application

This patch removes the function rb_shell_player_do_previous_or_seek() and moves the 3-second check from this function to rb_shell_player_do_previous().
This results in any 'previous' button currently found in RB to behave identical to other media players, standalone CD/DVD players and so on. Plugins do not have to be changed since they always called rb_shell_player_do_previous().
Comment 2 Jonathan Matthew 2008-04-08 12:40:46 UTC 
Committed to svn.

Since this was just moving bits of existing code around, I didn't think it necessary to ask about relicensing (bug 513617).