After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520851 - the fstab partitions not mounted in media should not be listed but they are
the fstab partitions not mounted in media should not be listed but they are
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] hal volume monitor
0.1.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 505214 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-06 21:36 UTC by Sebastien Bacher
Modified: 2009-01-10 04:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Fix for latest issue (4.00 KB, patch)
2008-03-07 14:18 UTC, Alexander Larsson 		none Details | Review

Description Sebastien Bacher 2008-03-06 21:36:10 UTC 
The current version lists all the mounts where only the user directory and media ones should be listed
Comment 1 David Zeuthen (not reading bugmail) 2008-03-06 23:21:00 UTC 
Fixed. Tested with these devices being referenced in /etc/fstab

 /dev/sdb1
 /dev/disk/by-uuid/47C2-1994
 LABEL=davidz
 UUID=47C2-1994
 UUID=47c2-1994

2008-03-06  David Zeuthen  <davidz@redhat.com>

        * hal/ghalvolumemonitor.c:
        (_g_unix_mount_point_guess_should_display),
        (should_be_hidden_according_to_etc_fstab),
        (should_volume_be_ignored), (should_drive_be_ignored),
        (update_drives), (update_volumes):
        Avoid showing volumes from /etc/fstab if the mount point is one
        that should not be displayed to the user (#520851)
Comment 2 David Zeuthen (not reading bugmail) 2008-03-07 03:51:18 UTC 
Just to clarify the devices mentioned in comment 1 all refer to the same device; I mentioned them to show we catch all possible cases:

 - regular special device
 - symlink to special device file
 - mount by label (e.g. LABEL=), 
 - mount by uuid (e.g. UUID=) (which case insensitive)).
Comment 3 Sebastien Bacher 2008-03-07 12:03:58 UTC 
reopening, that doesn't work, should_volume_be_ignored()  uses g_unix_is_mount_path_system_internal() on mounted partitions and not the new fstab logic and that doesn't consider if the mount is in media or not
Comment 4 Alexander Larsson 2008-03-07 14:18:19 UTC 
Created attachment 106785 [details] [review]
Fix for latest issue
Comment 5 André Klapper 2008-03-07 15:16:09 UTC 
(In reply to comment #4)
> Fix for latest issue

the "device_file_matches" gboolean is only set to FALSE and not used at all after that.
Comment 6 Alexander Larsson 2008-03-07 15:24:14 UTC 
commited with "device_file_matches" removed.
Comment 7 Matthias Clasen 2009-01-10 04:16:26 UTC 
*** Bug 505214 has been marked as a duplicate of this bug. ***