GNOME Bugzilla – Bug 520697
[API] Add GST_TAG_USER_RATING
Last modified: 2010-03-24 20:23:13 UTC
gst-plugins-base/gst-libs/gst/riff/riff-read.c GST_RIFF_INFO_IRTD used in wma/asf, not sure about wav, but apps should skip unknown items would be save to be added there too gst-plugins-good/gst/qtdemux/qtdemux_fourcc.h FOURCC_rtng (iso udta metadata) gst-plugins-base/gst-libs/gst/tag/gstid3tag.c id3v2.4.0 - POPM (4.17. Popularimeter)
oops, FOURCC_rtng is stuff like PG16 (parental guideance). RatingEntity Unsigned int(32) Four-character code rating entity RatingCriteria Unsigned int(32) Four-character code rating criteria
Got a patch for this ?
I think this needs more research what kind of rateing tags exist. mp4/real has rating for parental guidance [1][2] asf/avi/wav/id3 has rating in terms of personal popularity maybe we can do the asf/avi/wav/id3 thing as GST_TAG_POPULARITY and the mp4/real one as GST_TAG_AUDIENCE_RATING [1] http://en.wikipedia.org/wiki/Motion_picture_rating_system [2] http://service.real.com/help/library/guides/producer85/htmfiles/command.htm
Uploaded the wrong patch for tee. Will update the patch too and reupload.
Args. Wrong bug nr. Sorry.
Created attachment 156573 [details] [review] tags: Add new _FAVOURITE_RANKING tag Adds the new _FAVOURITE_RANKING tag so that users can set rankings to a media based on how much they like it.
Created attachment 156883 [details] [review] tags: Add new _USER_RATING tag Updated with comments from IRC, now we have _USER_RATING instead of _FAVOURITE_RATING
Review of attachment 156883 [details] [review]: Looks good to me. ::: gst/gsttaglist.c @@ +326,3 @@ + gst_tag_register (GST_TAG_USER_RATING, GST_TAG_FLAG_META, G_TYPE_UINT, + _("user rating"), + _("Rating attributed to a content by a user. The higher the rank, " I'd drop the 'to a content' bit. ::: gst/gsttaglist.h @@ +883,3 @@ + * GST_TAG_USER_RATING + * + * Rating attributed to a content by a person (likely the application user). Again, maybe drop the 'to a content'. @@ +884,3 @@ + * + * Rating attributed to a content by a person (likely the application user). + * The higher the rank the value, the more the user likes this media Drop 'the rank'.
(Tiny comment: The bugzilla link in the patch is wrong.) I think we should suggest a limit for the rating. Otherwise someone takes a rating from 1-5, others use 0-100 and then the ratings aren't comparable.
(In reply to comment #9) > (Tiny comment: The bugzilla link in the patch is wrong.) Heh, git-bz added that when I added the wrong number, thanks for spotting that. > > I think we should suggest a limit for the rating. Otherwise someone takes a > rating from 1-5, others use 0-100 and then the ratings aren't comparable. The docs says that is an uint from 0 to 100. I don't think we can programatically restrict it.
Pushed this. Do we want to add _PARENTAL_RATING here too? Module: gstreamer Branch: master Commit: e875577b0ff8d8fd06411059ad182e6cc55177e1 URL: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=e875577b0ff8d8fd06411059ad182e6cc55177e1 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Fri Mar 19 15:10:07 2010 -0300 tags: Add new _USER_RATING tag Adds a new tag for user favorite media rating. User rating informs how much (from 0 to 100) a user 'likes' a media. Having an percent uint range for this is easy to map into other scales, like some players that allow users to attribute 'stars' to its media. API: GST_TAG_USER_RATING Fixes #520697
Comment on attachment 156883 [details] [review] tags: Add new _USER_RATING tag Obsolete this one, pushed an updated version with the comments.
> Do we want to add _PARENTAL_RATING here too? Nah, let's wait until someone requests this explicitly in a separate bug report.