After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520550 - Add package and version to the test-report XML
Add package and version to the test-report XML
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: Tim Janik
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-03-05 17:28 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-06-15 06:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Add package and version to the test report XML (1011 bytes, patch)
2008-03-05 17:30 UTC, Emmanuele Bassi (:ebassi)
none Details | Review
[PATCH] Add package and version to the test report XML (3.01 KB, patch)
2008-03-10 14:03 UTC, Emmanuele Bassi (:ebassi)
none Details | Review
[PATCH] Add package and version to the test report XML (3.47 KB, patch)
2008-03-10 18:56 UTC, Emmanuele Bassi (:ebassi)
none Details | Review

Description Emmanuele Bassi (:ebassi) 2008-03-05 17:28:53 UTC
the XML report created by test-report should contain the package and version, so that applications reading this file can display this data.

another cool options would be:
- adding base directory (from top_srcdir)
- adding SCM information (like revision or commit object)

but those can wait.

patch attached.
Comment 1 Emmanuele Bassi (:ebassi) 2008-03-05 17:30:31 UTC
Created attachment 106632 [details] [review]
[PATCH] Add package and version to the test report XML

This patch adds the PACKAGE and VERSION using the Makefile.decl as tags to the generated XML. rationale: projects are going to copy Makefile.decl from GLib, and then tweaking it.
Comment 2 Tim Janik 2008-03-05 17:44:52 UTC
hm, i need to investigate if $PACKAGE and $VERSION can reasonably be expected to have the right values for most packages.
do you think you can extend the patch to cover gtester-report as well, so we can generate some sample HTML files for glib & gtk+ already?
Comment 3 Emmanuele Bassi (:ebassi) 2008-03-10 13:59:06 UTC
$PACKAGE and $VERSION are safe and used throughout an autotooled project.

here's a new patch, adding an <info> section (so we can expand it later) and patching gtester-report as well to produce a line in the HTML report.
Comment 4 Emmanuele Bassi (:ebassi) 2008-03-10 14:03:43 UTC
Created attachment 106969 [details] [review]
[PATCH] Add package and version to the test report XML

this patch adds the <info> section and makes gtester-report parse it and generate a line in the HTML report like this:

  <h3>Package: %(package)s, version: %(version)s</h3>
Comment 5 Emmanuele Bassi (:ebassi) 2008-03-10 18:56:52 UTC
Created attachment 107002 [details] [review]
[PATCH] Add package and version to the test report XML

same patch as above, but this makes gtester-report executable upon installation, so that the check in Makefile.decl that converts the XML into HTML.