After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520549 - Check for GNOME_DOC_INIT is broken for dasher
Check for GNOME_DOC_INIT is broken for dasher
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Phil Cowans
Phil Cowans
Depends on:
Blocks: 398103
 
 
Reported: 2008-03-05 17:20 UTC by Vincent Untz
Modified: 2008-03-22 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Untz 2008-03-05 17:20:14 UTC 
dasher does this:

if [[ x"$WITHGNOME" = xtrue ]]; then
  GNOME_DOC_INIT
else

The check is this:

	if grep "^GNOME_DOC_INIT" $basename >/dev/null; then
	    printbold "Running $GNOME_DOC_PREPARE..."
	    $GNOME_DOC_PREPARE --force --copy || exit 1
	fi

The check should allow spaces/tabs at the beginning of the line. I guess other checks should do the same too...
Comment 1 Christian Persch 2008-03-05 17:45:18 UTC 
Well. It always is a bug to call GNOME_DOC_INIT conditionally, since it calls AM_CONDITIONAL and therefore must not be used conditionally. You can use e.g.
GNOME_DOC_INIT([0.9.0],[have_gdu=yes],[have_gdu=no])
instead.
Comment 2 Vincent Untz 2008-03-05 17:50:02 UTC 
Ok, moving to dasher then.
Comment 3 Loïc Minier 2008-03-06 08:42:34 UTC 
Bug #520549 is related.

(BTW, aclocal seems to scan for macros whereever they are in the line; not sure whether checking for configure.in/.ac errors is a good thing.)
Comment 4 Aaron Larson 2008-03-06 15:09:06 UTC 
This may in fact be a duplicate of bug 398103, but for now I'm just going to say it is a blocker.  See bug 398103 attachment 106658 [details] [review] for hints towards a solution.
Comment 5 Aaron Larson 2008-03-22 13:21:20 UTC 
attachment 106658 [details] [review] applied in r3469.