After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520329 - [PATCH] mjpegtools: mplex ported to 0.10 and mpeg2enc updates/fixes
[PATCH] mjpegtools: mplex ported to 0.10 and mpeg2enc updates/fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-04 17:04 UTC by Mark Nauwelaerts
Modified: 2008-03-05 06:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for configure.ac (4.76 KB, patch)
2008-03-04 17:16 UTC, Mark Nauwelaerts 		committed Details | Review
mpeg2enc updates/fixes (17.26 KB, patch)
2008-03-04 17:25 UTC, Mark Nauwelaerts 		committed Details | Review
mplex port to 0.10 (56.37 KB, patch)
2008-03-04 17:28 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2008-03-04 17:04:02 UTC 
Subject says it pretty much; remains only to add that it has all been grouped together here (despite being separate plugins) for technical/administrative reasons, otherwise matters could get messy/unwieldy.

(connected) patches follow.
Comment 1 Mark Nauwelaerts 2008-03-04 17:16:50 UTC 
Created attachment 106563 [details] [review]
Patch for configure.ac

* Add checks for mplex.
* Clean up ever extending define's for evolving mjpegtools API's;
  provide a single API evolution allowing for cleaner #if'ing

[required by subsequent patches]
Comment 2 Mark Nauwelaerts 2008-03-04 17:25:20 UTC 
Created attachment 106564 [details] [review]
mpeg2enc updates/fixes

[depends on first patch for conditional defines]
* Streamline conditional code for evolving mjpegtools API.
* Optimize and fix/prevent crash in log handling.
* Use names/nicks for enums in the usual way.
* Minor updates in code and properties/settings.
* Make effort to provide timestamps on outgoing buffers
  (should help with cases like bug 504642)
Comment 3 Mark Nauwelaerts 2008-03-04 17:28:42 UTC 
Created attachment 106565 [details] [review]
mplex port to 0.10

* Port mplex to 0.10.
* Includes unit test.

[depends on first patch]
Comment 4 Sebastian Dröge (slomo) 2008-03-05 05:37:01 UTC 
2008-03-05  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Mark Nauwelaerts <manauw at skynet dot be>

	* configure.ac:
	Clean up detection of different mjpegtoolsAPI versions.

	* ext/mpeg2enc/gstmpeg2enc.cc:
	* ext/mpeg2enc/gstmpeg2enc.hh:
	* ext/mpeg2enc/gstmpeg2encoder.cc:
	* ext/mpeg2enc/gstmpeg2encoptions.cc:
	* ext/mpeg2enc/gstmpeg2encpicturereader.cc:
	* ext/mpeg2enc/gstmpeg2encpicturereader.hh:
	* ext/mpeg2enc/gstmpeg2encstreamwriter.cc:
	* ext/mpeg2enc/gstmpeg2encstreamwriter.hh:
	Streamline conditional code for evolving mjpegtools API,
	optimize and fix/prevent crash in log handling, use
	names/nicks for enums in the usual way andm inor updates
	in code and properties/settings. Partially fixes bug #520329.
Comment 5 Sebastian Dröge (slomo) 2008-03-05 06:02:33 UTC 
2008-03-05  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Mark Nauwelaerts <manauw at skynet dot be>

	* configure.ac:
	* ext/Makefile.am:
	* ext/mplex/Makefile.am:
	* ext/mplex/gstmplex.cc:
	* ext/mplex/gstmplex.hh:
	* ext/mplex/gstmplexibitstream.cc:
	* ext/mplex/gstmplexibitstream.hh:
	* ext/mplex/gstmplexjob.cc:
	* ext/mplex/gstmplexjob.hh:
	* ext/mplex/gstmplexoutputstream.cc:
	* ext/mplex/gstmplexoutputstream.hh:
	Port mplex element to 0.10. Fixes bug #520329.

	* tests/check/Makefile.am:
	* tests/check/elements/mplex.c: (test_sink_event), (setup_src_pad),
	(teardown_src_pad), (setup_mplex), (cleanup_mplex),
	(GST_START_TEST), (mplex_suite), (main):
	Add unit test for the mplex element.