After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520212 - handle multiple locations in the same timezone meaningfully
handle multiple locations in the same timezone meaningfully
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 513123 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-04 00:35 UTC by Matthias Clasen
Modified: 2008-04-07 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (12.16 KB, patch)
2008-03-04 00:36 UTC, Matthias Clasen 		committed Details | Review
FreeBSD patch (1.58 KB, patch)
2008-03-23 04:00 UTC, Pawel Worach 		none Details | Review

Description Matthias Clasen 2008-03-04 00:35:51 UTC 
Here is a patch that makes the clock remember the current location, instead of only the current timezone.
Comment 1 Matthias Clasen 2008-03-04 00:36:43 UTC 
Created attachment 106522 [details] [review]
patch
Comment 2 Sebastien Bacher 2008-03-05 11:20:47 UTC 
*** Bug 513123 has been marked as a duplicate of this bug. ***
Comment 3 Pawel Worach 2008-03-23 03:59:04 UTC 
The current implementation is also broken on FreeBSD, attached is a patch from Joe Marcus Clarke to use clock_location_guess_zone instead of zone_from_etc_sysconfig_clock. clock_location_guess_zone seems to be an abstration for /etc/sysconfig and zoneinfo scanning so this looks like what was intended here.
Comment 4 Pawel Worach 2008-03-23 04:00:05 UTC 
Created attachment 107849 [details] [review]
FreeBSD patch
Comment 5 Vincent Untz 2008-04-07 17:49:56 UTC 
Pawel, please open another bug with this patch. This bug is about something completely different.

Matthias, I've committed your patch. Note that you had already committed the clock.c part of the patch by accident. I made a slight change: we don't mark the location as the current one if it's marked as such in gconf when the system timezone is different from the location timezone. Else, it means logging in will change your timezone.