GNOME Bugzilla – Bug 519906
[API] add GstMixerOptions::get_values vfunc
Last modified: 2008-03-03 13:51:39 UTC
I'd like to add a GstMixerOptions::get_values() vfunc so GstMixerOption subclasses can implement/override gst_mixer_options_get_values(), which just returns mixeroptions->values.
This is needed/useful for mixer options whose list of available or currently selectable options can change throughout the life time of an object (as may be the case with OSS4).
Since the entire mixer API isn't thread-safe at all, mixer options implementation can't just change the GList *values member of the structure (even less so from a different thread that watches on an fd for changes). However, it would probably be fairly safe to do from within a _get_values() call from the application. For this, the implementation needs to be able to override gst_mixer_options_get_values().
Created attachment 106383 [details] [review]
Add get_value and documentation
Sounds like the best approach to me. In 0.11, we should use the ref-counting facilities of all those GObjects properly.
Yes, and return copied GLists etc.
2008-03-03 Tim-Philipp Müller <tim at centricular dot net>
* gst-libs/gst/interfaces/mixeroptions.c: (gst_mixer_options_init),
API: add GstMixerOptions::get_values vfunc (#519906)