After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519897 - Option to rename the current folder
Option to rename the current folder
Status: RESOLVED WONTFIX
Product: cowbell
Classification: Deprecated
Component: general
0.2.7.1
Other All
: Normal enhancement
: ---
Assigned To: Cowbell Maintainer(s)
Cowbell Maintainer(s)
gnome[unmaintained]
: 523954 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-02 13:25 UTC by info
Modified: 2014-02-24 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add folder renaming support (1.82 KB, patch)
2010-01-18 22:45 UTC, Andy Smith 		needs-work Details | Review

Description info 2008-03-02 13:25:50 UTC 
A nice feature would be an option to rename the current folder similar to the option to "rename files according to song information". the folder rename option would be something like "Interpret - Album" or "Interpret - Year - Album"
Comment 1 Brad Taylor 2008-05-04 22:12:13 UTC 
*** Bug 523954 has been marked as a duplicate of this bug. ***
Comment 2 Andy Smith 2010-01-18 22:45:14 UTC 
I've written a patch to add this functionality. Instead of adding a separate option it just allows the user to specify a "/" in the pattern.

Example:

Artist - Album/Track - Title
Comment 3 Andy Smith 2010-01-18 22:45:42 UTC 
Created attachment 151723 [details] [review]
Patch to add folder renaming support
Comment 4 Andy Smith 2010-01-18 22:48:15 UTC 
Expected bug if the artist or album (via example above) contains the directory separator. It might serve well to pre-normalize those in FilenamePattern.Parse.
Comment 5 Brad Taylor 2010-01-20 02:00:02 UTC 
Review of attachment 151723 [details] [review]:

Hey Andy -- this patch looks good overall.  A few nitpicks:

::: base/Song.cs
@@ +37,3 @@
 		public string Filename {
+				if (filename == value) {
+			set {

Unless you're going to raise an event, this if statement isn't strictly necessary.

::: base/services/DatabaseService.cs
@@ +159,3 @@
+					string currentdir = System.IO.Path.GetFileName (path);
+				if (!newdir.Equals (String.Empty)) {
+				string newdir = System.IO.Path.GetDirectoryName (filename);

You should also ensure that newdir exists.  Otherwise, you should create it.
Comment 6 André Klapper 2014-02-24 22:47:34 UTC 
This project is not under active development anymore. It is currently unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping (bug 725098) to reflect reality. Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.