GNOME Bugzilla – Bug 519634
Use gtk builder i.s.o. glade
Last modified: 2008-03-08 16:50:37 UTC
Patch coming up
Created attachment 106301 [details] [review] Patch Permission to apply?
Not making the same mistake twice. There's still no GtkBuilder editor, so no.
I'll add that if you integrate the gtk-builder-convert in the Makefiles, I'm happy to get this patch in. I just don't want to have to edit .ui files by hand.
Created attachment 106303 [details] [review] Updated patch generating ui file out of glade file Only minor issue is that with "make dist" the .ui file also ends up in the tarball. Not really a big issue but I don't know how to make sure to not get it in. I think you are referring to totem having builder files. Why didn't you keep the glade files around in SVN?
You also need to add data/file-share-properties.glade to the POTFILES.skip (try intltool-update -M in po/ and remove the warnings). As for file-share-properties.glade not going away, try DISTCLEANFILES = ...
(In reply to comment #4) > Created an attachment (id=106303) [edit] <snip> > I think you are referring to totem having builder files. Why didn't you keep > the glade files around in SVN? We came in too early, and you had to do changes by hand after running the script. They're still in SVN for reference though.
(In reply to comment #5) > You also need to add data/file-share-properties.glade to the POTFILES.skip (try > intltool-update -M in po/ and remove the warnings). Done > As for file-share-properties.glade not going away, try DISTCLEANFILES = ... > I wanted file-share-properties.ui to go away I feel that the approach we're taking is not the best one. 1) We're having file-share-properties.ui in POTFILES.in, but file-share-properties.ui doesn't exist in SVN 2) If someone add gtkbuilder support to glade or gazpacho we need to change make files again. So I propose to have the glade file and the ui file in svn. Only disadvantage is that you have to run gtk-builder-convert manually when you edit the glade file. This is in my opinion a small price to pay. Furthermore when glade and gazapacho support gtkbuilder files we simply need to remove the glade file
Created attachment 106319 [details] [review] Patch with the idea proposed in previous comment
No, I want people's changes to the .ui to be lost for now. Either that, or just wait for an editor to get GtkBuilder support.
Created attachment 106333 [details] [review] Generate the ui file like requested. Everything including translations is now still based on the glade file. The gtkbuilder file gets generated when running make.
Please detect gtk-builder-convert in configure.in using AC_PROG_PATH(), and it should be ready to commit.
Created attachment 106844 [details] [review] Updated patch. Checking for gtk-builder-convert in configure.in
I believe you can remove that line: +AC_SUBST(GTK_BUILDER_CONVERT) Rest looks good to commit. Thanks.
2008-03-08 Jaap Haitsma <jaap@haitsma.org> * configure.in: * data/Makefile.am: * src/file-share-properties.c: (flush_password), (update_ui), (main): Move from libglade to gtkbuilder. Fixes bug #519634