GNOME Bugzilla – Bug 519587
Navigating nested lists with Collection not functioning properly
Last modified: 2008-03-19 17:00:14 UTC
Navigating nested lists with Collections is not functioning properly. This problem was seen in the original "'go to' with Collections" bug. The original comment is posted below: Okay, cycle 3 was fine with one exception: Going to the previous list with Shift+L in a page with nested lists. The test is html_struct_nav_lists.py Other structural navigation (at least in terms of the regression tests) worked as expected.
Created attachment 106304 [details] [review] first version of Navigating nested lists with Collection not functioning properly The patch fixes the nested list navigation problem but I occasionally see a very bizarre problem. On test/html/lists.html I occassionally see the following: Actual: "0. remember what the heck we are doing each day" Expected: "1. remember what the heck we are doing each day" and Actual: "0. And use roman numerals," Expected: "VI. And use roman numerals," The problem occurs for Braille and Speech (sorry, I couldn't reproduce the actual problem for this posting). The bogus '0' comes directly from the text interface and I have only seen it during the tests, never through Accerciser or manual testing. I am sure it is the same version of Firefox so I am not sure what the problem is. The fix also includes a similar fix for listitems even though they passed on the regression tests. I wonder if we should beef up the listitem regression tests to include listitems that are focusable. I believe the test would have failed if this type of listitem were included. pylinted to 10.00
The bogus '0' problem used to occur for me but disappeared 2 or 3 weeks ago (FF fix I think rather than anything we're doing differently, but I'm not sure). What FF build are you using? As for beefed up tests, we need a lot more tests and some beefed up versions of our existing tests. If you already have such a test for list items, that would be awesome. Otherwise, I'll add a beefier list item test to my list (so to speak). :-) Thanks for pointing it out.
Created attachment 106351 [details] [review] second version of Navigating nested lists with Collection not functioning properly same as first patch except for removal of test/harness/runone.sh debug change. I used a fully updated version of Firefox and I am certain the regression test version and manual testing version were the same. In addition, I also used the regression test Firefox profile during manual testing. I never once saw the '0.' issue during manual testing, but consistently got it during regression testing. The issue went away only after I fully solved the Collection navigation issue. I then ran the regression test two times successfully. Strange!
I've tested this on several pages with lists. It seems to be working OK. I'd say after it passes the regression tests it should be ready for trunk.
committed to trunk. Bug report to remain open to track gnome2-22 back porting.
First coarse pass at GNOME 2.24 planning.
Just to verify - we were going to backport this into Orca v2.22.1, correct? My understanding is that the reason we didn't do it for v2.22.0 was just that we were so close to the deadline. Scott, can you verify this is the right thinking please?
That is correct Will. Let me know if you need me to do the work.
(In reply to comment #8) > That is correct Will. Let me know if you need me to do the work. > Hey - if you're into it and have the time, go for it! :-) Much appreciated.
Committed to .../branches/gnome-2-22. pylinted to 10.00 Passes list/list item regression tests. Marked as FIXED.