GNOME Bugzilla – Bug 518914
table column number missing in whereAmI info
Last modified: 2009-03-10 00:04:40 UTC
Please describe the problem: When the cursor is inside a table, both column and row info should be presented when whereAmI is performed. Currently only row number is given. Steps to reproduce: using any table, place the cursor inside the table and ask whereAmI Actual results: current speech output: "table (pause) cell (pause) <cellcontent> row x of y" Expected results: would like to hear: "table (pause) cell (pause) <cellcontent> (pause) row x of y, column a of b" Does this happen every time? yes Other information:
Thanks Jon. This is what we do as part of generic whereAmI. So... Mike: Should we alter whereAmI for all of Orca so that column numbers are spoken as well? (The custom StarOffice.py whereAmI does that, so perhaps it's worth doing across the board) OR, do we want to leave generic whereAmI as is and add support similar to what is in StarOffice.py to Gecko.py?
I'd be in favor of making this change across the board.
Across the board it is then. :-) We might be able to sneak this into 2.22 if that's desirable because I believe Rich's implementation in StarOffice.py already introduces the string we need for the column. (Will, if we do that, we're not violating other freezes are we? -- assuming we get it in before code freeze)
(In reply to comment #3) > Across the board it is then. :-) > > We might be able to sneak this into 2.22 if that's desirable because I believe > Rich's implementation in StarOffice.py already introduces the string we need > for the column. (Will, if we do that, we're not violating other freezes are > we? -- assuming we get it in before code freeze) > Well...we don't want to sneak. That's bad. You get caught and you're labeled as being sneaky for a long long time. Perhaps forever. :-( But, this isn't necessary something that falls under a UI freeze in the GUI sense, and we're not going to cause any doc writer to need to change docs. Same goes for any of the other freezes. So, if the change is safe and has high user impact, it's probably OK to get it in.
any progress on this? or is it the sneekiness factor that is blocking us at the moment :) Thanks
Nah, it's the "need to come up for air" factor I'm afraid. I'll look at it this weekend.
Created attachment 106998 [details] [review] revision 1 Because Orca presents column information before row information, I did the same here rather than followed the exact example in the opening comment. This should work in regular ol' gtk tables, HTML tables, and also in OOo Writer tables which is completely new. Currently whereAmI in Writer sees that we're in a paragraph (as opposed to a table cell) and the table cell stuff never happens. I think this change works nicely. Updated gtk-demo tests included. Please test. Rich, when you get back.... I went mucking with StarOffice.py again. Mind taking a look? It turns out that "Calc" is no longer part of the frame name, but rather the root pane name so isSpreadSheetCell() was failing. I ran the regression tests, and the change I made fixes some other problems (removing bogus '0's from the braille context). But many of the oocalc tests fail (independent of this patch and unaltered by it), so who knows what else changed in OOo? Thanks!
Oh, I forgot to mention, if you try this in a table with a caption in FF3, there is a Firefox bug (which they claim is now fixed, but they're wrong) which causes us to get bogus column numbers. We have bug 515665 to track that issue.
Looks like Marco already filed the XUL issue here: https://bugzilla.mozilla.org/show_bug.cgi?id=421922 I opened a tracking bug here: http://bugzilla.gnome.org/show_bug.cgi?id=521634
First coarse pass at GNOME 2.24 planning.
Sorry to take so long to get to this. Joanie, you StarOffice.py script changes look fine to me. thanks for asking.
Created attachment 107685 [details] [review] revision 2 - removes the StarOffice.py changes The changes made in revision 1 of the patch to StarOffice.py need to be made anyway, independent of this patch. And Rich needs those changes now as part of his work on fixing the OOo regression tests. See bug #523459. Therefore this patch removes the StarOffice.py changes. Once Rich has checked in his patch, it would be helpful to have some testing on this one. Thanks!
This seems correct
Thanks Joanie, works well, but again we miss-report things when the table has a caption, although i could have sworn they fixed it, cant find it now though. running rev 3753 ff30b5 from yesterday. ok to commit though, since i think we are tracking table caption elsewhere.
Just an FYI...I missed this new string: + text = _("column %d of %d") % ((column + 1), table.nColumns) I think this is also not a critical showstopper, so I moving this out of 2.22.x as a result.
Patch committed to trunk. Moving to pending.