After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518772 - hal-ipod-info should set properties for ipod
hal-ipod-info should set properties for ipod
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
unspecified
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-26 04:53 UTC by David Zeuthen (not reading bugmail)
Modified: 2009-01-13 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ipodsleuth-icon-name.patch (757 bytes, patch)
2008-03-13 23:16 UTC, Bastien Nocera
committed Details | Review

Description David Zeuthen (not reading bugmail) 2008-02-26 04:53:44 UTC
Didn't find a bugzilla for libipoddevice so dumping it here.

With the new gvfs hal volume monitor, certain properties are read from the hal

 info.desktop.icon  # an icon name
 info.desktop.name  # the name to use for the device

that can be set both the storage and volume device objects. The hal-ipod-info callout should set these properties after it has investigated the ipod. For example

 info.desktop.icon -> "multimedia-player-ipod-video-white"
 info.desktop.name -> "David Zeuthen's iPod"

on the device object representing the drive (e.g. /dev/sda), and then, presto, this icon (including fallbacks) and name will be used throughout the desktop for all of it's volumes.

(Btw, in passing I thought i should mention that the gphoto2 backend just got merged into gvfs. That means that MTP devices are now available through gio just as if they were mass storage device. We still need to implement writing, it's read-only at the moment.)
Comment 1 Bastien Nocera 2008-03-13 23:16:28 UTC
Created attachment 107254 [details] [review]
ipodsleuth-icon-name.patch

For the icon name. PodSleuth doesn't seem to read the volume name though.
Comment 2 Gabriel Burt 2009-01-13 17:15:26 UTC
Thanks for the patch Bastien, closing as fixed.