After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518507 - getSpeechForAlert() assumes unrelated labels have names
getSpeechForAlert() assumes unrelated labels have names
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-02-24 23:25 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-02-28 21:34 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
revision 1 (540 bytes, patch)
2008-02-24 23:28 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-02-24 23:25:45 UTC
Steps to reproduce:

1. Launch FF3 (a fairly recent build)
2. In the location bar, type "javascript:alert('hello world')" and 
   press Return

Expected results:  Orca would announce the alert's title (JavaScript application) and then speak the contents (hello world)

Actual results:  Orca only announces the alert's title

If you look at the label for the "hello world" text in Accerciser, you will find that the label does not have a name (as one might expect *sigh*), but instead exposes the text through the text interface.  Perhaps we should be using getDisplayedText() instead.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-02-24 23:28:45 UTC
Created attachment 105880 [details] [review]
revision 1

Pylinted.  Not yet regression tested.  Will, does this change make sense?
Comment 2 Willie Walker 2008-02-25 14:25:40 UTC
This seems to make sense to me, and I believe it is definitely better than just looking at label.name. If it tests well, I say commit.  Thanks!
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-02-25 21:41:27 UTC
Thanks.  It tests well.  :-) Committed to both the gnome-2-22 branch and to trunk.  Moving to pending.