GNOME Bugzilla – Bug 518507
getSpeechForAlert() assumes unrelated labels have names
Last modified: 2008-02-28 21:34:34 UTC
Steps to reproduce: 1. Launch FF3 (a fairly recent build) 2. In the location bar, type "javascript:alert('hello world')" and press Return Expected results: Orca would announce the alert's title (JavaScript application) and then speak the contents (hello world) Actual results: Orca only announces the alert's title If you look at the label for the "hello world" text in Accerciser, you will find that the label does not have a name (as one might expect *sigh*), but instead exposes the text through the text interface. Perhaps we should be using getDisplayedText() instead.
Created attachment 105880 [details] [review] revision 1 Pylinted. Not yet regression tested. Will, does this change make sense?
This seems to make sense to me, and I believe it is definitely better than just looking at label.name. If it tests well, I say commit. Thanks!
Thanks. It tests well. :-) Committed to both the gnome-2-22 branch and to trunk. Moving to pending.