After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518502 - Orca doesn't always speak wrapping announcement for link structural nav in FF3
Orca doesn't always speak wrapping announcement for link structural nav in FF3
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.21.x
Other All
: Normal minor
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-02-24 22:19 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed patch (1.76 KB, patch)
2008-02-24 22:23 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-02-24 22:19:20 UTC 
Steps to reproduce:

1. Find/create a page of links.

2. Follow the first and last link on the page (i.e. so that they
   are visited).

3. On the link page, use U and Shift+U to navigate among the
   unvisited links.

Expected results:  When Orca wraps, it will announce that it has wrapped.

Actual results: When Orca wraps, it doesn't announce that it has wrapped.

Similar results can be seen if the first and last link are unvisited and V/Shift+V is used.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-02-24 22:23:11 UTC 
Created attachment 105876 [details] [review]
proposed patch

Wrapped is set to True when we do the wrap.  If the first thing we come across is not the right state (visited/unvisited), we set wrap to False and keep looking.  At this point, wrapped will be False so we don't make the announcement.  We need to make the announcement if wrapped is True *or* wrap is False.
Comment 2 Mike Pedersen 2008-02-25 00:44:22 UTC 
Seems to work just fine.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-02-25 01:17:59 UTC 
Thanks Mike.  Patch (and updated regression test) committed.  Moving to pending.