After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517570 - wnckprop fails to write geometry because of missing mainloop
wnckprop fails to write geometry because of missing mainloop
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-19 23:19 UTC by Mikkel Kamstrup Erlandsen
Modified: 2008-02-20 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Run window prop writes in a Gtk main loop (941 bytes, patch)
2008-02-19 23:20 UTC, Mikkel Kamstrup Erlandsen 		needs-work Details | Review

Description Mikkel Kamstrup Erlandsen 2008-02-19 23:19:06 UTC 
In response to bug 448183.

It appears wnckprop has a bug when writing window properties. Basically the probelm is that there is no main loop when it tries to call set_geometry.

Attaching a simple (maube too simple) patch in a sec.
Comment 1 Mikkel Kamstrup Erlandsen 2008-02-19 23:20:06 UTC 
Created attachment 105614 [details] [review]
Run window prop writes in a Gtk main loop

As promised
Comment 2 Mikkel Kamstrup Erlandsen 2008-02-19 23:22:39 UTC 
PS: The reason why I stuff the gtk_main_quit in a timeout handler is that I get warnings about a missing main loop otherwise.
Comment 3 Vincent Untz 2008-02-19 23:42:29 UTC 
It shouldn't be needed. If it doesn't work, it might mean there's a missing XSync() somewhere.

Bah. Stupid bug in _wnck_set_window_geometry():

  _wnck_error_trap_push ();
  XSendEvent (gdk_display,
              RootWindowOfScreen (screen),
              False,
              SubstructureRedirectMask | SubstructureNotifyMask,
              &xev);
  _wnck_error_trap_push ();

The second one should be a pop. I can't test the fix right now, but I expect it to work so I committed it. Please reopen if it doesn't work.
Comment 4 Mikkel Kamstrup Erlandsen 2008-02-20 09:14:55 UTC 
It works. Thanks.