Created attachment 105472 [details] [review]
evolution-vcf-import

patch provides a command-line tool to import VCF data. patch can, atm, process
only a single VCARD component :(

patch can be improved to accept VCF data from files rather than the
command-line, but we already have a funky GUI importer to do that ;-)

the address of the FSF in that patch is wrong and outdated :)

a) for comment #2. Is it same as in bug #517124?

b) you use opt_addressbook_folder_uri to print g_warning even it can be NULL.

c) report errors to user, thus he/she will know why it failed.

d) please add file import with wild cards support.
   I cannot imagine passing multiline vCard as parameter to the program, it can
   contains quotes and other funny characters, so I guess it can be damaged in 
   command line parser. Isn't stdin better for this?

e) exit versus return and N_() versus _() ?

As I was told on IRC:
f) please also check for duplicates, before adding new contact into the book

*** Bug 309073 has been marked as a duplicate of this bug. ***

Just like for bug 517124:
"
You should also add a .desktop file with NoDisplay=true so it can register the
mime-types.

It should probably also show the contact, and offer the user to either
dismiss the dialogue, or add it to their local addressbook. It should also check
for duplicates and show them to the user before adding them to the addressbook.
"

Bumping version to a stable release.

Is bug 325621 a dupe ?

*** Bug 325621 has been marked as a duplicate of this bug. ***

Downstream bug https://bugzilla.novell.com/show_bug.cgi?id=438677

as of 2.29.92.1 (as packaged in debian as 2.29.92.1-1), the new importer only works if the working directory of a previously running evolution instance is the same as the instance trying to import (at least if relative file names are used).

the second instance should either detect that its arguments are supposed to mean a file and convert to absolute paths, or send its current working directory to the main instance.

this situation typically does not arise if all program starts come from guis (say, gnome panel launcher and file imported by firefox), but can easily happen if evolution is called from the command line.


additionally, i'd like to suggest to add a small preview to the import assistant (at least event title and date) -- otherwise, events are blindly imported into a calendar and the user might not even know how the event is called.

The original request works (double-click a vcf file, an import dialogue shows up). I opened bug 711758 about comment 11.