GNOME Bugzilla – Bug 517070
Last.fm Password Stored in Plain Text
Last modified: 2008-03-31 22:22:07 UTC
Last-Exit store the user's last.fm password in plain text in the gconf key /apps/lastexit/password Launchpad Bug #187958: https://bugs.edge.launchpad.net/ubuntu/+source/last-exit/+bug/187958
I'm working on it, expect some code this weekend...
One question - shall I make a clean upgrade path from gconf to gnome-keyring? It will make some ugly if's in the code IMHO...
I don't really know how to judge what the best way to do this is. A clean path would be better for the user as they wouldn't have to deal with any thing to get their password out of plain text, but as Lukasz said it would be kind of ugly. Any LastExit dev have an opinion?
I think Lukasz counts as a last-exit dev more than me, but I agree with him, it should be in the gnome-keyring
Created attachment 107555 [details] [review] Use GNOME keyring to store the password Sorry that it took so long, I had to scrape my first attempt of this patch. It's still needed to fix the autohell to use/search gnome-keyring-sharp (from the mono repository - where would the world be without Alp T. ;). Is someone experienced with it? I don't want to start another flamewar here because of auto* ;)
Actually the message box code is borked, I will remake the patch without it. Currently I have no idea where it should be included but that's maybe because of the flu...
Created attachment 107638 [details] [review] Use GNOME keyring to store the password In this one all code paths actually work (yay for the pills ;) and it adds some trivial styling fixes to the class.
Argh, some debug code got into the patch...
Created attachment 107692 [details] [review] Adds Gnome Keyring support together with complete autofoo OK, this patch adds the required GNOME Keyring sources and proper auto* support together with the support in last-exit itself.
Tried to test this, but make failed in chroot environment (pbuilder). ./Config.cs(25,13): error CS0234: The type or namespace name `Keyring' does not exist in the namespace `Gnome'. Are you missing an assembly reference? ./Config.cs(25,1): error CS0246: The type or namespace name `Gnome.Keyring' could not be found. Are you missing a using directive or an assembly reference? ./Config.cs(25,13): error CS0234: The type or namespace name `Keyring' does not exist in the namespace `Gnome'. Are you missing an assembly reference? ./Config.cs(25,1): error CS0246: The type or namespace name `Gnome.Keyring' could not be found. Are you missing a using directive or an assembly reference? Compilation failed: 4 error(s), 0 warnings make[3]: *** [last-exit.exe] Error 1 make[3]: Leaving directory `/tmp/buildd/last-exit-5/src'
Could you attach the output from configure or configure.log? It certainly works for me - just tested it again with a clean checkout
The above error happened when trying to add the patch to the current Ubuntu source package. Just did a svn check out and everything compiles fine. The patch works as expected. There is no longer a password in plain text in gConf. Thanks for your work!
This patch doesn't work for me w/ a clean SVN checkout. I keep getting the "You need to have GNOME Keyring installed" dialog, even though gnome-keyring-daemon is running. Not sure if this is a problem w/ my box (running gentoo 2.6.23, mono 1.2.6, gnome-keyring/manager 2.20.0(3)), or the patch...
Could execute 'env | grep GNOME_KEYRING' for me on the console you run last-exit from? Also can you check if you have the keyring libs built with dbus support?
This is in trunk for testing towards LE 7.
(In reply to comment #14) > Could execute 'env | grep GNOME_KEYRING' for me on the console you run > last-exit from? Also can you check if you have the keyring libs built with dbus > support? Sorry, I should have thought of that. As you suspect, the environment variables weren't being exported (and I missed seeing the WITH_DBUS conditional symbol in the patch). When I export GNOME_KEYRING_SOCKET or build with -d:WITH_DBUS, then everything works great. There should probably be some autofoo to check for dbus and add the symbol if found in gnome-keyring-sharp/Makefile.am. Thanks.
Created attachment 108294 [details] [review] Build gnome-keyring-sharp with WITH_DBUS symbol Since dbus-sharp should always be used (either as an external lib, or the internal build), gnome-keyring-sharp should always be built with the WITH_DBUS conditional symbol. Add the autofoo to Do The Right Thing.
Yes, I thought of the same just after posting my previous comment, but I had no time to patch it, sorry. Thank you very much the patch, I hope Brandon will apply it soon!
Done. Closing bug.