After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517014 - Too many internal strings marked for translation
Too many internal strings marked for translation
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-02-17 15:39 UTC by Wouter Bolsterlee (uws)
Modified: 2009-09-30 16:26 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---


Attachments
Replace function names by %s in error messages (8.73 KB, patch)
2009-06-19 07:42 UTC, Claude Paroz
committed Details | Review

Description Wouter Bolsterlee (uws) 2008-02-17 15:39:07 UTC
Is there a reason strings like the few examples I pasted below are marked for translation? This results in a lot of work for translators and the loss of 'googlability' of (debug) messages.

msgid "Invalid return value from get_info"
msgid "Invalid return value from query_info"
msgid "Couldn't get stream file descriptor"
msgid "Invalid return value from call"
msgid "Didn't get stream file descriptor"
msgid "Invalid return value from open"
msgid "Invalid return value from query_filesystem_info"
msgid "Invalid return value from monitor_dir"
msgid "Invalid return value from monitor_file"
Comment 1 Wouter Bolsterlee (uws) 2008-09-17 21:11:42 UTC
It's too late to get this in for Gnome 2.24 (string freeze!), but please fix this in the next cycle.
Comment 2 André Klapper 2009-02-05 18:35:47 UTC
uws, is this really a 2.26 blocker anymore?
looks more like a "nice to have" to me...
Comment 3 Wouter Bolsterlee (uws) 2009-02-05 19:40:12 UTC
It's not urgent, but annoying. Too bad it won't go in this time either :(
Comment 4 Alexander Larsson 2009-02-22 08:23:27 UTC
The problem is that all GError return messages are translated, because they might be shown in the user interface.
Comment 5 André Klapper 2009-06-13 16:42:07 UTC
So is this a WONTFIX as per last comment?
Comment 6 Matthias Clasen 2009-06-18 18:37:11 UTC
At the very least, we can go to

"Invalid return value from %s"
Comment 7 Claude Paroz 2009-06-19 07:25:56 UTC
I'm going to cook a patch as per Matthias comment.
Comment 8 Claude Paroz 2009-06-19 07:42:23 UTC
Created attachment 136975 [details] [review]
Replace function names by %s in error messages
Comment 9 Cosimo Cecchi 2009-09-30 13:20:25 UTC
Comment on attachment 136975 [details] [review]
Replace function names by %s in error messages

Thanks, please commit to master.
Comment 10 Claude Paroz 2009-09-30 16:25:40 UTC
Comment on attachment 136975 [details] [review]
Replace function names by %s in error messages

commit ebe371a3e0b09bd15d89fab6eb5016abce83d3fc
Author: Claude Paroz <claude@2xlibre.net>
Date:   Fri Jun 19 09:36:04 2009 +0200

    Bug 517014 – Factorize error messages marked for translation