After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516844 - Build fix + drop gnome-vfs dependency
Build fix + drop gnome-vfs dependency
Product: epiphany-extensions
Classification: Deprecated
Component: build infrastructure
Other Linux
: Normal blocker
: gnome-2-24
Assigned To: epiphany-extensions-maint
: 516954 (view as bug list)
Depends on:
Reported: 2008-02-16 13:13 UTC by Cosimo Cecchi
Modified: 2008-10-18 08:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

patch (21.45 KB, patch)
2008-02-16 13:14 UTC, Cosimo Cecchi
none Details | Review
patch v2 (20.51 KB, patch)
2008-02-16 13:16 UTC, Cosimo Cecchi
committed Details | Review
[PATCH] Remove gnomevfs dep from favicon extension (2.29 KB, patch)
2008-09-09 19:35 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review

Description Cosimo Cecchi 2008-02-16 13:13:43 UTC
After the change in epiphany.pc, epiphany-extensions do not build anymore.
Also, ephy-file-helpers.h has changed with the gio transition and some extensions which made use of that do no longer build.
I made a patch to drop gnome-vfs dependency and fix these build issues.
Comment 1 Cosimo Cecchi 2008-02-16 13:14:05 UTC
Created attachment 105378 [details] [review]
Comment 2 Cosimo Cecchi 2008-02-16 13:16:27 UTC
Created attachment 105379 [details] [review]
patch v2

Oops, I left a snippet from another unrelated patch in there.
Comment 3 Xan Lopez 2008-02-17 18:32:19 UTC
*** Bug 516954 has been marked as a duplicate of this bug. ***
Comment 4 Christian Persch 2008-02-18 01:10:45 UTC
Looks good; thanks!

It seems the adblock filter rules are loaded sync, in the UI thread? If so, maybe we should have a follow-up to use async loading there, so as to not block the UI.
Comment 5 Cosimo Cecchi 2008-02-18 19:08:56 UTC
Committed to trunk.

r1672 | cosimoc | 2008-02-18 20:08:12 +0100 (lun, 18 feb 2008) | 3 lines

Drop gnome-vfs dependency and fix the build.
Bug #516844.
Comment 6 Stefan Stuhr 2008-03-12 23:04:09 UTC
The favicon (Python) extension still imports and uses GnomeVFS.

I suggest replacing the use of GnomeVFS in this extension with the standard Python urlparse[1] module:

			uriparts = urlparse.urlsplit(embed.get_property('address'))
			single = epiphany.ephy_shell_get_default().get_embed_single()
			backend = single.get_backend_name();
			if uriparts[0] == "http" or (uriparts[0] == "https" and backend != "gecko-1.7") :
				url = urlparse.urlunsplit(uriparts[:2] + ("/favicon.ico", "", ""))
				embed.set_property('icon_address', url)

The code piece above is not tested (I only have GNOME 2.20 installed).

Comment 7 André Klapper 2008-08-14 16:59:09 UTC
reopen as per last comment.
Comment 8 André Klapper 2008-08-29 15:32:07 UTC
any news? 2.23.91 tarballs due is on this monday.
Comment 9 André Klapper 2008-09-09 15:40:31 UTC
Hardcode Freeze on next Monday!
Comment 10 Christian Persch 2008-09-09 17:32:45 UTC
(In reply to comment #9)
> *ping*
> Hardcode Freeze on next Monday!

Not for e-e since it's not in any gnome release suite :)
Comment 11 Cosimo Cecchi 2008-09-09 17:48:23 UTC
Ok, so there's no need to set the gnome target, right? :)
Comment 12 Christian Persch 2008-09-09 18:40:01 UTC
Comment 13 Diego Escalante Urrelo (not reading bugmail) 2008-09-09 19:00:57 UTC
I'll commit something in a while.
Comment 14 Diego Escalante Urrelo (not reading bugmail) 2008-09-09 19:35:51 UTC
Created attachment 118379 [details] [review]
[PATCH] Remove gnomevfs dep from favicon extension

Remove the gnomevfs dependency of and pythonify the source.
gnomevfs was replaced with urlparse, patch by Stefan Stuhr, closes: 516844
 extensions/favicon/ |   43 +++++++++++++++++++++-------------------
 1 files changed, 23 insertions(+), 20 deletions(-)
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2008-09-09 19:37:45 UTC
Committed to trunk and gnome-2-24.

Page info still uses gnome_vfs!
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2008-10-18 08:01:34 UTC
Cosimo already removed it by commenting the parts that were old galeon stuff anyway, closing as fixed.