Bug 516697 – ui locks up

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 516697 - ui locks up


Summary:	ui locks up


Status:	RESOLVED FIXED

Product:	cheese
Classification:	Applications
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Cheese Maintainer(s)
QA Contact:	Cheese Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-02-15 16:39 UTC by Matthias Clasen
Modified:	2008-02-15 20:46 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
add missing locking (673 bytes, patch) 2008-02-15 16:40 UTC, Matthias Clasen	none	Details \| Review

Description Matthias Clasen 2008-02-15 16:39:37 UTC

Ever since the camera-setup-in-thread patch was merged, cheese ui locks up for me as soon as the webcam starts playing. 

Here is a patch that fixes it. 

Morale: be careful when playing with threads....

Comment 1 Matthias Clasen 2008-02-15 16:40:08 UTC

Created attachment 105343 [details] [review]
add missing locking

Comment 2 Jaap A. Haitsma 2008-02-15 19:50:13 UTC

Thanks for your patch.
After reading [1] I wonder why you don't put the ephy_spinner_stop into the critical section. It also calls gtk functions


[1] http://library.gnome.org/devel/gdk/unstable/gdk-Threads.html#gdk-threads-enter

Comment 3 Matthias Clasen 2008-02-15 20:36:08 UTC

well, the docs for ephy_spinner would have to say whether iti is sujpposed to be called with the gdk lock held or not. But I assume you are right.

Comment 4 Jaap A. Haitsma 2008-02-15 20:46:38 UTC

Thanks

2008-02-15  Jaap Haitsma <jaap@haitsma.org>

        * src/cheese-window.c:
          Put gtk calls in critical section in thread
          Fixes bug #516697. Patch by Mathias Clasen <mclasen@redhat.com>