After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516491 - Crashing on malformed savefile
Crashing on malformed savefile
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
2.21.x
Other Linux
: Normal critical
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 534008 537089 544357 562294 577635 592164 593189 593493 594316 595405 595644 596693 598333 598498 599921 601117 601131 603064 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-14 16:25 UTC by Claude Paroz
Modified: 2009-11-26 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
problematic saved game (1.38 KB, text/plain)
2008-02-14 17:01 UTC, Claude Paroz
Details

Description Claude Paroz 2008-02-14 16:25:56 UTC
The first time was OK, the current game was saved after quitting. The second
time, I started a new game, then quitted. The third time, I'm getting this
error.


Distribution: Ubuntu 7.10 (gutsy)
Gnome Release: 2.21.91 2008-02-12 (JHBuild)
BugBuddy Version: 2.18.1

System: Linux 2.6.22-14-generic #1 SMP Tue Feb 12 07:42:25 UTC 2008 i686
X Vendor: The X.Org Foundation
X Vendor Release: 10300000
Selinux: No
Accessibility: Enabled
GTK+ Theme: Clearlooks
Icon Theme: gnome

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout:
0 it_real_value: 0 frequency: 0



----------- .xsession-errors (5785 sec old) ---------------------
(evolution:25280): e-data-server-DEBUG: Loading categories from
"/home/claude/.evolution/categories.xml"
(evolution:25280): e-data-server-DEBUG: Loaded 29 categories
Loading Spamassasin as the default junk plugin
(gnome-screenshot:7274): atk-bridge-WARNING **: AT_SPI_REGISTRY was not started
at session startup.
(gnome-screenshot:7274): atk-bridge-WARNING **: IOR not set.
(gnome-screenshot:7274): atk-bridge-WARNING **: Could not locate registry
(gedit:6996): atk-bridge-WARNING **: AT_SPI_REGISTRY was not started at session
startup.
(gedit:6996): atk-bridge-WARNING **: IOR not set.
(gedit:6996): atk-bridge-WARNING **: Could not locate registry
--------------------------------------------------
Traceback (most recent call last):
  • File "/opt/gnome2/bin/gnome-sudoku", line 58 in ?
    start_game()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/gnome_sudoku.py", line 21 in start_game
    main.start_game()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 1036 in start_game
    profile_me()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 1053 in profile_me
    prof.runcall(start_game)
  • File "/opt/gnome2/lib/python2.4/hotshot/__init__.py", line 76 in runcall
    return self._prof.runcall(func, args, kw)
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 1039 in start_game
    u = UI()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 200 in __init__
    if self.select_game():
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 64 in _
    ret = fun(ui,*args,**kwargs)
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/main.py", line 214 in select_game
    choice = game_selector.NewOrSavedGameSelector().run_swallowed_dialog(self.swallower)
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/game_selector.py", line 177 in run_swallowed_dialog
    self.setup_dialog()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/game_selector.py", line 76 in setup_dialog
    self.make_saved_game_model()
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/game_selector.py", line 137 in make_saved_game_model
    sudoku.sudoku_grid_from_string(g['game'].split('\n')[1].replace(' ','')).grid,
  • File "/opt/gnome2/lib/python2.4/site-packages/gnome_sudoku/sudoku.py", line 232 in sudoku_grid_from_string
    assert(len(s)<=GROUP_SIZE**2) AssertionError

Comment 1 Claude Paroz 2008-02-14 16:36:29 UTC
I debugged the error and here's the s variable content raising the error:
'0841003000700080010100007898None30590020096None1508100820904601000000400300090008004200'

The problem seems to be some None value herein.
Comment 2 Claude Paroz 2008-02-14 17:01:32 UTC
Created attachment 105257 [details]
problematic saved game
Comment 3 sthoenna 2008-04-18 05:36:49 UTC
I've had this same problem twice recently.  If it would be helpful, I can attach the bad saved games.
Comment 4 Robert Ancell 2008-11-05 05:56:21 UTC
*** Bug 537089 has been marked as a duplicate of this bug. ***
Comment 5 Robert Ancell 2008-11-05 06:13:59 UTC
*** Bug 534008 has been marked as a duplicate of this bug. ***
Comment 6 palfrey 2008-11-26 15:59:22 UTC
*** Bug 562294 has been marked as a duplicate of this bug. ***
Comment 7 Ian Abbott 2009-01-07 17:15:06 UTC
I hit this bug in gnome-sudoku 2.24.2.  Editing the saved game file to replace the 'None' with '0' allows the game to start up properly.
Comment 8 Thomas Andersen 2009-03-28 02:10:04 UTC
Fixed on trunk. The patch ignores malformed save files.
http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8911

The fix will be in 2.27.1. Potential 2.26.x material...
Comment 9 Thomas Andersen 2009-04-07 00:40:16 UTC
Committed to 2.26 branch. Will be in 2.26.1
Comment 10 Thomas Andersen 2009-04-07 00:41:54 UTC
*** Bug 577635 has been marked as a duplicate of this bug. ***
Comment 11 Fabio Durán Verdugo 2009-08-22 03:52:41 UTC
*** Bug 592164 has been marked as a duplicate of this bug. ***
Comment 12 Fabio Durán Verdugo 2009-08-26 18:34:00 UTC
*** Bug 593189 has been marked as a duplicate of this bug. ***
Comment 13 Fabio Durán Verdugo 2009-08-29 16:44:25 UTC
*** Bug 593493 has been marked as a duplicate of this bug. ***
Comment 14 Fabio Durán Verdugo 2009-09-06 17:20:38 UTC
*** Bug 594316 has been marked as a duplicate of this bug. ***
Comment 15 Fabio Durán Verdugo 2009-09-17 03:18:59 UTC
*** Bug 595405 has been marked as a duplicate of this bug. ***
Comment 16 Fabio Durán Verdugo 2009-09-21 01:23:04 UTC
*** Bug 595644 has been marked as a duplicate of this bug. ***
Comment 17 Fabio Durán Verdugo 2009-09-29 16:20:34 UTC
*** Bug 596693 has been marked as a duplicate of this bug. ***
Comment 18 Akhil Laddha 2009-10-14 03:58:09 UTC
*** Bug 598333 has been marked as a duplicate of this bug. ***
Comment 19 Akhil Laddha 2009-10-15 02:56:24 UTC
*** Bug 598489 has been marked as a duplicate of this bug. ***
Comment 20 Akhil Laddha 2009-10-15 02:56:55 UTC
*** Bug 598498 has been marked as a duplicate of this bug. ***
Comment 21 Fabio Durán Verdugo 2009-10-28 17:17:47 UTC
*** Bug 599921 has been marked as a duplicate of this bug. ***
Comment 22 Fabio Durán Verdugo 2009-10-28 17:19:31 UTC
*** Bug 544357 has been marked as a duplicate of this bug. ***
Comment 23 Fabio Durán Verdugo 2009-11-08 01:27:59 UTC
*** Bug 601117 has been marked as a duplicate of this bug. ***
Comment 24 André Klapper 2009-11-08 13:22:38 UTC
*** Bug 601131 has been marked as a duplicate of this bug. ***
Comment 25 Fabio Durán Verdugo 2009-11-26 19:04:28 UTC
*** Bug 603064 has been marked as a duplicate of this bug. ***